Re:How terrible code gets written by sane people
by edblarney on Monday February 20, 2017 @12:18PM
(#13688983)
There should be no need for 'wars' or even 'negotiation'.
It's the managers decision - not the developers, really.
The devs can lay out what can be done, and describe what the results will be if various paths are chosen.
'Skip the tests' - you get quality issues, but better schedule.
'Write perfect code' - you get quality, but it could take to long.
The old saying: 'fast' 'quality' or 'cheap' -> pick 2.
If your team is having problems because of bike-shedding over details, or messed up code - this is altogether another issue and needs to be addressed differently.
I have seen developers "push back for the right thing" in a way that basically amounted to angry emotional outburst over things manager did not understood. The dude thought he is pushing for the right thing, but everyone else thought he does not listen to their needs, refuses to follow the company vision of the product replacing it by his own. (They wanted simplest possible functionality and fast, he was constantly adding own requirements to "make it better". When the same person pushes for yet another refactoring, management does not trust him.)
The other thing to understand is that some experienced lead remembers teams that were given time, no deadlines and all the good stuff and then produced mess anyway, procrastinated and took long time to do it. I have seen that happen and I have also seen that ended in long wars over petty differences in style and opinions. Sometimes the mess is result of people doing something knew and thus bad decisions along the way. Code review alone wont solve that, because the reviewer may be the one forcing mistake on others.
You need to communicate in the way that will ensure the manager that he or she is not in the above situation.