Add Reactions to Pull Requests, Issues, and Comments

Re:Add Reactions to Pull Requests, Issues, and Comments by dpflan on Thursday March 10, 2016 @05:13PM (#11262891)

I like the idea of adding more expressiveness, pictorially capturing sometimes fleeting moments of emotion or accurately representing an emotional state that can occur.

These are the following reactions:

  1. +1
  2. -1
  3. smile
  4. thinking_face
  5. heart
  6. tada

Do they capture the necessary expressiveness for the context? Facebook's reactions cover more emotions, but FB is trying to support reaction to anything that can be posted.

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by mayank on Thursday March 10, 2016 @05:17PM (#11262929)

Considering that it's Github, how about things relevant to software engineering, like: agree, disagree, support, insightful, obsolete, misleading. I can't imagine it being helpful to know that someone felt "heart" about an issue comment.

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by xentronium on Thursday March 10, 2016 @05:38PM (#11263089)

Heart is probably a supersized +1 for pull requests and a nod to Aaron Peterson.

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by dfc on Thursday March 10, 2016 @05:51PM (#11263164)

who is aaron peterson? Googling that name results in a photographer,a lawyer and a bunch of doctors.

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by dcgoss on Thursday March 10, 2016 @06:08PM (#11263259)

Perhaps he meant Aaron Patterson (https://github.com/tenderlove) "tenderlove"? Not sure.

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by eric_h on Thursday March 10, 2016 @06:04PM (#11263234)

aaron patterson, aka @tenderlove. rails and ruby core contributor.

[edit: at least that's who I presume the GP meant]

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by robszumski on Thursday March 10, 2016 @06:12PM (#11263288)

this was my initial reaction is well. It seems like this will just add to the noise and not help large open source projects get work done.

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by z1mm32m4n on Thursday March 10, 2016 @05:24PM (#11262979)

I was a little surprised that neither :ship: nor :shipit: made the list; it seems like these frequently show up in discussions as well.

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by dpflan on Thursday March 10, 2016 @05:32PM (#11263049)

Right, more domain-specific options would make sense.

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by minimaxir on Thursday March 10, 2016 @05:22PM (#11262966)

I recently wrote a post about Facebook Reactions and if it would be effective at helping quantify sentiment. (http://minimaxir.com/2016/02/facebook-reactions/) The tl;dr is that I believe that Reactions are redundant outside of positive/negative classification.

GitHub actually has both +1 and -1, which satisfies me. But there's not much productive purpose with a smile/heart/tada other than to be quirky. (The thinking_face is neutral and adds nothing in this aspect)

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by dpflan on Thursday March 10, 2016 @05:31PM (#11263032)

Yeah, as I asked below: Will this be a meaningful form of communication and is the language (subset of images) sufficient? Can small changes like this perhaps change how PRs, Comments, etc are treated? Will it be productive, a distraction, or a NOOP?

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by monsk on Thursday March 10, 2016 @05:17PM (#11262920)

All I want is slack's :partyparrot: and I'm satisfied.

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by laughinghan on Thursday March 10, 2016 @05:47PM (#11263142)

You may be interested to know that :partyparrot: is not built-into Slack, someone on your team had to add it: http://cultofthepartyparrot.com/

...which I just did to my team's Slack.

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by fineline on Thursday March 10, 2016 @05:33PM (#11263056)

Four positive, one neutral, one negative. Balanced?

Where is the sadface to go with smile? The warface to go with heart? Or the facepalm to go with party?

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by TranquilMarmot on Thursday March 10, 2016 @05:40PM (#11263098)

I don't understand why they limited it to six responses rather than just letting you search for one and use it (the same way slack does)?

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by brbcoding on Thursday March 10, 2016 @07:30PM (#11263707)

I actually don't have :thinking_face: but have :confused: instead.

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by qwyxzy on Thursday March 10, 2016 @09:58PM (#11264366)

I think GitHub wanted an option to express "I don't understand this," and decided :confused: was a better fit. Which makes sense, because :thinking_face: could mean "I'm considering this" or "Interesting point," which is not, I think, what that option is meant to convey.

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by danvayn on Thursday March 10, 2016 @05:23PM (#11262976)

Eh...what's the point?

[ Parent | on HN ]

Re:Add Reactions to Pull Requests, Issues, and Comments by dpflan on Thursday March 10, 2016 @05:26PM (#11262997)

I think the point is: Will this be a meaningful form of communication and is the language (subset of images) sufficient? Can small changes like this perhaps change how PRs, Comments, etc are treated? Will it be productive, a distraction, or a NOOP? Would you use this feature or have you used a feature like this?

[ Parent | on HN ]