News for hackers. Stuff that matters.
Re:YouTube change served lower-quality video to Firefox 43 f... by pmontra on Monday January 11, 2016 @08:49AM (#10880714)
Solution found:

> The comments on FF for Android do not have any additional indentation to suggest they are children.

I reinstalled FF on my phone and you're right. On my tablet FF behaves like Chrome. Some media queries gone awries or some FF quirk on smaller screens? FF-desktop behaves like the one on the phone when the window is resized to be narrow so it seems to be consistent with itself.

HN is using a media query to set the indentation using an empty image and setting its width. Check the /news.css file. Each comment is a tr, with 3 td elements. The image is the first one, then the votes arrows and the text. FF arranges those td in vertical, blink keeps them on the same row.

Digging into the CSS I realized that it's because of the display: block at line 88. If I remove it FF indents the comments. Opera keeps looking good.

Re:YouTube change served lower-quality video to Firefox 43 f... by bzbarsky on Monday January 11, 2016 @09:36AM (#10880935)
Oh, that's awesome.

The CSS is clearly setting these to display:block, so they should in fact stack. But the page is also in quirks mode (no doctype), and in quirks mode Chrome (and WebKit) seems to compute the display of <td> to "table-cell" no matter what the styles say.

So yeah, someone just wrote CSS that depends on a bug in Chrome/WebKit and either didn't bother to test in other browsers or doesn't care whether it works there.

Edit: https://code.google.com/p/chromium/issues/detail?id=369979 is the 1.5-year-old bug report on Chrome to remove this unnecessary quirk. Let's see what HN does if/when the Chrome folks fix that one...

Re:YouTube change served lower-quality video to Firefox 43 f... by pmontra on Monday January 11, 2016 @09:58AM (#10881057)
Interesting explanation. Thanks.

Btw this could prove my point that people ditch browsers because of bugs of sites, if those sites look good in other browsers.

Re:YouTube change served lower-quality video to Firefox 43 f... by bzbarsky on Monday January 11, 2016 @10:05AM (#10881103)
Thank _you_ for actually digging into the CSS and finding the problem!
Re:YouTube change served lower-quality video to Firefox 43 f... by rubberstamp on Monday January 11, 2016 @10:15AM (#10881177)
This is awesome, as expected from tech crowd. As soon as I got time to look into this, someone else has figured it all out.

Many eyes/brains on the bug means quickly figuring out issues. If it was open source the patch for this would probably be in testing now.

Active and very Awesome community!!

Re:YouTube change served lower-quality video to Firefox 43 f... by tripzilch on Tuesday January 12, 2016 @03:53AM (#10886273)
quirksmode, table-cells... I don't think the problem here is the browser.
Re:YouTube change served lower-quality video to Firefox 43 f... by dang on Tuesday January 12, 2016 @03:36AM (#10886230)
Bravo pmontra! We've rolled that out.

I'm ashamed to say that this fix was on our list for a month and we hadn't gotten to it despite how easy it turned out to be (assuming, at least, that nothing breaks in other browsers). Fortunately HN has excellent users.

Re:YouTube change served lower-quality video to Firefox 43 f... by pmontra on Tuesday January 12, 2016 @05:31AM (#10886555)
I checked the site with FF on my phone and it really works. Maybe I can start using FF there. Thanks for deploying the patch so quickly.
Re:YouTube change served lower-quality video to Firefox 43 f... by pelario on Tuesday January 12, 2016 @04:18AM (#10886330)
Opera Mini in android lost the indentation of comments around two months ago :(
Re:YouTube change served lower-quality video to Firefox 43 f... by dang on Tuesday January 12, 2016 @06:16PM (#10891168)
Is it still broken?
Re:YouTube change served lower-quality video to Firefox 43 f... by pelario on Thursday January 14, 2016 @09:40AM (#10901608)
It works now, thanks a lot !
Re:YouTube change served lower-quality video to Firefox 43 f... by skarap on Monday January 11, 2016 @01:23PM (#10882089)
A CSS fixing the layout on Firefox based on your solution: https://gist.github.com/skarap/15bf77d63fe596ee55ce . Use Stylish (https://addons.mozilla.org/en-US/firefox/addon/stylish/) to load it.
Re:YouTube change served lower-quality video to Firefox 43 f... by skarap on Monday January 11, 2016 @12:07PM (#10881632)
> Solution found:

Thank you for caring enough to look into this!

Would be absolutely awesome if we could find somebody from HN to fix it.