News for hackers. Stuff that matters.
Re:How I got XSS’d by my ad network by proactivesvcs on Tuesday July 14, 2015 @07:16AM (#9884017)
"When you allow third parties to run script on your site, you’re entirely beholden to them; they can run anything they like in the context of your site"

I've seen a fair few Internet banking web sites pulling scripts from over a dozen third parties, mostly for tracking and advertising, but even for trivial things like social media. On their customer login pages. It's beyond me how they can consider this to be an acceptable risk.

Re:How I got XSS’d by my ad network by jameshart on Tuesday July 14, 2015 @11:33AM (#9885686)
The issue here isn't so much that they can run anything they like - it's not implied that the provider intentionally put a cross-site scripting vulnerability into the code. The issue is that you don't get to audit the third party code for vulnerabilities, and vulnerabilities can be introduced without your knowledge.

But that is part of the tradeoff you make when you agree to accept money from someone to add their code to your site.

If someone offers you a hundred bucks to carry a bag onto a plane for them, you'd be right to be suspicious. Ah, but it's not just a random stranger. You were introduced to them by your buddy, the ad network. So that's okay then. Your ad provider wouldn't be dealing with anybody who was actually criminal. But what about negligent? Did they pack the bag themself? Have they let it out of their sight?

When you run ads on your site, remember which direction the money is flowing in, and remember who is the customer.

Ad networks are a trust broker. The ad provider wants to know their ad really was shown to a real person in a real web browser, who really does meet the demographic profile they are paying to target. They do not trust you, the publisher, at all. And they are paying.

You, as the publisher, are getting money from the ad network to compensate you for the inconvenience of surfacing the advertiser's content on your site. And of proving that you aren't defrauding them. To do that, you are going to give up some control.

And that includes control over whether the code you're serving is secure.

Re:How I got XSS’d by my ad network by leni536 on Tuesday July 14, 2015 @07:58AM (#9884162)
I wonder how many websites' users would be compromised if code.jquery.com got hacked.
Re:How I got XSS’d by my ad network by nly on Tuesday July 14, 2015 @09:02AM (#9884493)
I've been saying this for years. It's not even just security: you're also potentially leaking all your visitor stats to a third party (IP, user agent, the pages they visit (via the Referer)), and effectively giving jquery.com a third party supercookie over thousands of domains.

I surf with third party cookies and referers (via RefControl) disabled, and these should be the defaults

Re:How I got XSS’d by my ad network by danielweber on Tuesday July 14, 2015 @09:40AM (#9884767)
I've been called an idiot (even here on HN) for being paranoid about loading scripts from all over the web. I think it's a losing battle and my side is going the way of the dinosaurs.
Re:How I got XSS’d by my ad network by bsilvereagle on Tuesday July 14, 2015 @09:49AM (#9884825)
As tools like uBlock and uMatrix get widespread adoption more and more people are realizing how much extraneous junk is being loaded by webpages. I think your side is slowly but surely gaining followers.
Re:How I got XSS’d by my ad network by jdmichal on Tuesday July 14, 2015 @11:34AM (#9885694)
I use uMatrix, and I have already whitelisted loading scripts from common CDNs as global rules. They're everywhere and I found myself just constantly whitelisting them anyway.

The trend for a long time was to cite using a CDN as a best practice, but no one ever calls out the downsides when making such statements. In this case, you lose control of the code and allow third-party access to your users' browsers.

Re:How I got XSS’d by my ad network by nly on Tuesday July 14, 2015 @11:50AM (#9885818)
To be fair, it has some positives: like said CDN being able to patch somelib.js to fix a security issue and thereby protect thousands of sites at once.

At the moment though, proposed solutions to trusting third parties with your Javascript, like the W3C proposal to put cryptographic hashes in to your <script> tags etc, don't even consider these potential positives. So we're likely going to end up with the worst of both worlds.

If anything this is just enough facet of the weakness of the web as an app platform (Real solution: all sites serving client side libs should use package management, scripts should be digitally signed by the authors). As it stands it's far too common for people to just unzip WordPress or whatever in to their docroot, and so server-side code doesn't even get updated, let alone client-side code.

Re:How I got XSS’d by my ad network by IanCal on Tuesday July 14, 2015 @11:29AM (#9885654)
Which is an interesting problem as to stop loading all these scripts I have to give another script access to everything I see.
Re:How I got XSS’d by my ad network by bsilvereagle on Tuesday July 14, 2015 @01:58PM (#9886792)
If you download the source for uBlock/uMatrix, and run locally you avoid the auto-updating of the add-on while being able to vet the source.
Re:How I got XSS’d by my ad network by IanCal on Friday July 17, 2015 @05:07PM (#9905339)
Thank you, that's an extremely good idea.
Re:How I got XSS’d by my ad network by leni536 on Tuesday July 14, 2015 @09:21AM (#9884625)
The same could be told about other third party resources, like images and css files, too.
Re:How I got XSS’d by my ad network by nly on Tuesday July 14, 2015 @09:33AM (#9884712)
Maybe, but hotlinking images has historically been considered rude at best, and theft at worst. And most people still host their own CSS because it tends to come with whatever app, or theme, they're using.

In any case, the defaults I live with cover all the other web resources too.

Re:How I got XSS’d by my ad network by leni536 on Tuesday July 14, 2015 @11:48AM (#9885803)
Re:How I got XSS’d by my ad network by anc84 on Tuesday July 14, 2015 @10:09AM (#9884985)
> you're also potentially leaking all your visitor stats

Not just potentially but (f)actually!

Re:How I got XSS’d by my ad network by glomph on Tuesday July 14, 2015 @10:33AM (#9885147)
Could this be illegal? I mean the EU for example has pretty strict requirements on what you can do with user information.
Re:How I got XSS’d by my ad network by fastest963 on Tuesday July 14, 2015 @11:27AM (#9885630)
Which is why they're adding Subresource integrity to script tags so you can detect when a popular CDN/host is hacked and not load the script: http://w3c.github.io/webappsec/specs/subresourceintegrity/#h...
Re:How I got XSS’d by my ad network by tarpherder on Tuesday July 14, 2015 @11:50AM (#9885816)
How would that help? The "integrity" packet is provided by the now hacked server, and thus can never provide extra security? Or am I missing something?
Re:How I got XSS’d by my ad network by ryan-c on Tuesday July 14, 2015 @12:23PM (#9886082)
The integrity value is part of the script tag. You add a hash of the script content as a property of the script tag, and the browser only executes if it matches.

I hacked together something that implements this sort of behavior in a script loader a while ago, if you're interested: https://github.com/ryancdotorg/VerifyJS

Re:How I got XSS’d by my ad network by tarpherder on Wednesday July 15, 2015 @11:21AM (#9891762)
Ah I see, thanks for explaining.

So, though this does allow one to safely circumvent the hosting cost associated with bigger third party scripts, it means giving up some of the advantages like dynamic updates (as the hash would now be incorrect), right? This would therefore not work when ad providers want to be able to supply content they get dynamically from others right?

Re:How I got XSS’d by my ad network by ryan-c on Wednesday July 15, 2015 @11:49AM (#9891962)
Many of the CDNs will let you reference a specific version of the script. If you didn't do this, and there were an update, the script wouldn't load and you'd have to update your site. My script allows callbacks to be specified for a bad hash, so you could be notified of this, and the subresource integrity draft also mentions this as a good idea.

It seems not uncommon for ad networks to dynamically load further scripts/content, which would not fall under the hash. You can just sandbox them off in an iframe, though.

An obvious extension would be signed scripts, which would re-enable trusted updates of a script in a CDN, but there is the question of how that would be implemented.

Re:How I got XSS’d by my ad network by mayrun on Tuesday July 14, 2015 @08:15AM (#9884240)
doesnt have to be literally "hacked", just a change of the dns records is enough.
Re:How I got XSS’d by my ad network by leni536 on Tuesday July 14, 2015 @08:22AM (#9884278)
Well, once you hotlink jquery in your website at least use the https link (assuming your site is on https too).
Re:How I got XSS’d by my ad network by nothrabannosir on Tuesday July 14, 2015 @08:34AM (#9884341)
No need; the browser will block http:// included from https:// pages. Including from a http:// page? Then a compromised jquery cdn is the least of your worries.

In short; no, just a compromised dns record is not enough.

Re:How I got XSS’d by my ad network by mayrun on Tuesday July 14, 2015 @09:15AM (#9884584)
if it is a http:// page, then even a small change in the local host file is enough.
Re:How I got XSS’d by my ad network by mrweasel on Tuesday July 14, 2015 @10:20AM (#9885056)
>"they can run anything they like in the context of your site"

Some of them actually depend on that. We seen weird stuff show up on our sites because we made a deal with a company that sells ads for us. Suddenly we're pulling in stuff from companies we never heard of because the ad reseller made a deal with a third-party, which then again outsource part of their infrastructure to a fourth company. It's hours of detective work when you need to figure out who has misconfigured https.