Every story and comment from the Hacker News API, in a layout borrowed from 2001.
A comment on Ask HN: How do you do code review, if at all?.
- starts as a pull request (we use git-flow strategy)
- Pull request is announced in our team slack channel via integration
- 2 devs must sign off before merge; 3 if branch is from our outsourced team in India.
- Github project wiki contains an outline of the type of criteria to keep an eye out for, mostly syntax & patterns not caught by our linter config
- All feedback is considered optional
- Devs are encouraged to take conversations offline if a comment thread takes off on a particular item
- Team leader handles the merge after devs signoff on PR
There are no comments on this comment yet.
- starts as a pull request (we use git-flow strategy)
- Pull request is announced in our team slack channel via integration
- 2 devs must sign off before merge; 3 if branch is from our outsourced team in India.
- Github project wiki contains an outline of the type of criteria to keep an eye out for, mostly syntax & patterns not caught by our linter config
- All feedback is considered optional
- Devs are encouraged to take conversations offline if a comment thread takes off on a particular item
- Team leader handles the merge after devs signoff on PR