> [...] nor have I ever heard systematic criticism of Github's methodology.
He's not only criticizing Github: > (a) make a real pull request, not the braindamaged crap that github
> does when you ask it to request a pull: real explanation, proper email
> addresses, proper shortlog, and proper diffstat.
>
> (b) since github identities are random, I expect the pull request to
> be a signed tag, so that I can verify the identity of the person in
> question.
Real explanation, proper shortlog, signed commit, etc. (Note that he didn't mention emojis.)All he seems to be asking for is that we take our time and do it properly. Makes all the sense in the world for a large, long-lived open source project like Linux. Imagine 20-year-old commit messages from FreeBSD would look like the ones we write today for, say, a npm module.
--- edit ---
Yeah ... nevermind. He explains it himself further down:
> Btw, Joseph, you're a quality example of why I detest the github
> interface. For some reason, github has attracted people who have zero
> taste, don't care about commit logs, and can't be bothered.
>
> The fact that I have higher standards then makes people like you make
> snarky comments, thinking that you are cool.
>
> You're a moron.
>
> LinusHere is Linus himself commenting on that exchange: https://lkml.org/lkml/2013/7/16/712
Another source for what was said: https://news.ycombinator.com/item?id=3962978
That's our Linus-kun.
Here is more of the exchange for context:
--- Umm. Notice how the "Joseph" I replied to had deleted all the comments he wrote?
That should tell you something. I smacked down a troll.
If I was polite to you all those years ago, and I was polite but firm in the two first responses, please give me credit for when I smack somebody down. There may be a reason for it. The fact that the person deleted his messages (or github deleted them for him - I have no idea what their comment policy is) and you cannot see that context any more online should not make you think that I suddenly went crazy.
Btw, since I get the github messages in email too, I have a copy. Joseph replied to those "polite but firm" messages where I explained exactly why I don't want to bother with github pull requests with this gem:
"I did not realizes that Linus' shit does not stink. Thanks for
clearing that up..."---
Github doesn't scale at all for large projects. The kernel is averaging over 8 changes an hour, 24 hours a day. That rate of change can never be handled by doing pull requests and web site review. It only can work with email and review and scriptable processes.
That's roughly one every other hour, so still not quite on the same level. And we do use tooling _in addition_ to GitHub, but reviews are done in PR and not over email.
(FWIW I personally wish more projects worked like the kernel's, but such is life)
By the way, we've been succesfully using Gerrit on smaller-scale projects as well (around 8 change-requests / day) and don't even want to think about going back to pull-requests.
Criticisms in the interview were essentially about low discipline that Github interface allows, and how they were not willing to adapt to the kernel needs, not about fundamental deficiencies of pull request based model.
So far nothing has been said about why pull requests via a website might handle less load than pull requests over email.
http://www.mcvoy.com/lm/bitmover/lm/talks/socal/
tl;dr: fan in/fan out scales great if you have BitKeeper or Git.
That's partly because of how the kernel is developed, but part of it was that the GitHub interfaces were actively encouraging bad behavior. Commits done on GitHub had bad commit messages etc, because the web interfaces at GitHub were actively encouraging bad behavior. They did fix some of that, so it probably works better, but it will never be appropriate for something like the Linux kernel.
I haven't ever looked at the kernel workflow, nor have I ever heard systematic criticism of Github's methodology. Does anyone else have input on what Linus may mean by his opinion?