Silly code comments you've left to yourself

Re:Silly code comments you've left to yourself by staunch on Friday December 28, 2007 @08:53AM (#93191)

I can't think of any silly comments from my code right now, but I have a new one for you :-)

  # ...your computer really doesn't care if you seperate the password from the nonce with a dash; it's a computer, not a 2nd grade teacher[1]
  echo 'MD5(): ' . md5(date('ymdHis', time()) . 'password-is-yummy-salty-safety-' . $pw);

1. http://www.matasano.com/log/958/enough-with-the-rainbow-tabl...

[ Parent | on HN ]

Re:Silly code comments you've left to yourself by matth on Friday December 28, 2007 @03:52PM (#93309)

My computer also doesn't care if I put a space between each concatenation operator, but I do. :)

[ Parent | on HN ]

Re:Silly code comments you've left to yourself by marcus on Friday December 28, 2007 @11:10AM (#93214)

Actually using time as an additional salt is a very healthy practice, just make sure you store the time you use.

It reduces collisions.

[ Parent | on HN ]

Re:Silly code comments you've left to yourself by sohail on Friday December 28, 2007 @12:56PM (#93242)

You might as well use random salts.

[ Parent | on HN ]