Most legal systems, demonstrated here by the ABA model rules of professional conduct for lawyers, would not consider this a conflict of interest, unless the lawyer were arguing for both sides in the same case. See Rule 1.7.
In these tribunals, government and corporate parties aren't two sides of every fight, they're arbitrary categories of parties. All good legal systems allow private parties to bring suit against the government. NAFTA Ch. 11 is an example of a very similar system working well to address legitimate disputes. See cases where a corporation's claim was rejected, and they were forced to pay attorney's fees to the country they sued in the tribunal. Not exactly the outcome predicted here.
The "tribunals" are arbitral tribunals and as such are manned by lawyers chosen and agreed on by BOTH sides - just like any other arbitral tribunal. They can apportion compensation for damages caused by breaches of international law. No international court can "force" a state to change a law (this is constitution 101), and it is not the case here.
Philip Morris is seeking compensation for the purported expropriation of intellectual property rights (their brand). Almost no-one believes they have any chance of winning. In fact, it seems that they are doing it solely to press for time in other jurisdictions: i.e. some countries are waiting for the result of the arbitration before introducing similar laws. They probably figured out that potential lost profits in foreign markets in that time frame are likely higher than legal fees.
Not one of your points is accurate (and you reference John Oliver and a comic).
Would that nation-state eventually feel pressured to change its laws to avoid crippling fines?
This is not a bug but a feature: the ISDS is designed to ensure that states abide by international law and respect the terms of the free trade agreement they consented to. This is fully in line with the concept of pacta sunt servanda and the relationship between international and municipal law.
Finally, if you are the United States, you can also simply ignore the arbitral tribunal and continue to be in breach of the agreement and international law, because, well, what are they gonna do?
The most egregious, obvious, and deep-cutting error is that you equate money with wealth, which is made obvious when you contrast "investing in the economy" with "just sitting on the money" as if these were two different things. Money is not goods and services; money is a claim on goods and services. Therefore, hoarding or "just sitting on" money is not hoarding goods and services, but closer to the opposite. It is deliberately not commanding the goods and services one's money could command, freeing up those goods and services to be used by others. Hoarding money is a kind of anti-hoarding of resources; it's exactly equivalent to investing in an index fund over the entire economy.
For his reason, your whole argument is confused. Please consider the nature of money more carefully and stop misleading people.
Note: I'm opposed to the TPP, but most certainly not because it promotes "free trade."
The specific issue the EFF article is pointing out is how the ISDS is designed to trumps national sovereignty, so business can strong-arm countries into removing any law they don't like.
It works more or less like this:
1) pass TPP as a treaty, which by definition has the same power as a constitutional amendment. (this is probably a serious bug in the constitution). This means TPP trums congress.
2) TPP sets up an international tribunal (ISDS) that hears complaints from businesses. (i.e. "Australia is hurting our tobacco sales with their plain packaging laws"[2])
3) The tribunal, as mentioned in this article, would be staffed by, "three private-sector attorneys who take turns being the judge and the corporate advocate." This conflict of interest would be a serious violation of ethics requirements in most legal systems.
4) The tribunal rules that your local law violates some foreign requirement, as determined by the ISDS and their business-assigned judges, and the local legislature is forced to repeal the law. ("Australia's plain packaging laws is seizing the trademarks of Philip Moriss, in violation of a 1993 trade agreement if we carefully abuse the agreement's language")
That's the short version, and I'm leaving out some details, of course. It should work as a decent overview of ISDS is a threat to national sovereignty.
[1] http://economixcomix.com/home/tpp/
[2] this example is covered well by John Oliver: https://www.youtube.com/watch?v=6UsHHOCH4q8
edit: oops.. s/ISPS/ISDS/