Re:Knightmare: A DevOps Cautionary Tale (2014)
by paulrademacher on Tuesday February 03, 2015 @09:34PM
(#8994995)
Code review could have been another set of eyes to predict the problem of reusing a flag.
[ Parent
| on HN ]
Re:Knightmare: A DevOps Cautionary Tale (2014)
by solarmist on Tuesday February 03, 2015 @09:41PM
(#8995024)
If the message was as compact and low level as possible it was probably a bit flag, so in that context it makes sense to repurpose it.
Being so removed from binary and bit level interactions it can be easy to forget things like this.
Re:Knightmare: A DevOps Cautionary Tale (2014)
by saalweachter on Tuesday February 03, 2015 @11:26PM
(#8995299)
I agree with the GP; I don't think code reviews or testing was the problem.
I think the best-practices they violated is that they deprecated and repurposed a flag within a single release cycle. That sort of activity should take two release cycles at least, one to remove the old functionality and one to add the new functionality.