News for hackers. Stuff that matters.

A comment on What would you do? Boss thought I copied code from Web. Parent comment

Re:What would you do? Boss thought I copied code from Web by smileysteve on Wednesday August 20, 2014 @05:13PM (#8204672)
> "inner JavaScript classes" are inappropriate for enterprise code. I asked him to explain what he was talking about - he meant my object constructors

I'd guess that he and the product do not tend to use javascript objects when writing code - which means that the code was above his (and the product's average) coding head. This also means that it wasn't the best way for you to code the project.

For a code review to pass, the reviewer should think about the minimum person working on the project and whether they would understand or make guesses when fixing it - or at least know where / when to get help.

[ Parent | on HN ]
Re:What would you do? Boss thought I copied code from Web by tryanother on Wednesday August 20, 2014 @05:21PM (#8204717)
Thank you for that feedback. These are the kinds of thing I can't learn on my own. There is absolutely no formal code review, much to my surprise; in fact, the closest thing to "process" here is to push to UAT as fast as humanly possible. I would love to work in an environment where I felt as though I were actually learning from my coworkers and from the process.
[ Parent | on HN ]