> "inner JavaScript classes" are inappropriate for enterprise code. I asked him to explain what he was talking about - he meant my object constructors

I'd guess that he and the product do not tend to use javascript objects when writing code - which means that the code was above his (and the product's average) coding head. This also means that it wasn't the best way for you to code the project.

For a code review to pass, the reviewer should think about the minimum person working on the project and whether they would understand or make guesses when fixing it - or at least know where / when to get help.

Thank you for that feedback. These are the kinds of thing I can't learn on my own. There is absolutely no formal code review, much to my surprise; in fact, the closest thing to "process" here is to push to UAT as fast as humanly possible. I would love to work in an environment where I felt as though I were actually learning from my coworkers and from the process.

It sounds like he barely has any idea what he's talking about...or you two are talking about totally different things. Has this happened before with him? Has he done this to anybody else?

I only know his history in broad strokes. He has a "reputation," I just don't know the specifics. He hated the guy that I replaced - 3 months later and he is still publicly bad mouthing the guy. Very unprofessional, makes for a hostile work environment.

Is taking him out for a beer an option? I'd recommend nipping this kind of thing in the bud as quickly as possible; or it'll just spiral out of control.

If you can: be diplomatic, take him out for drinks after work one day and have a heart-to-heart. He wields a significant amount of power, and it'd be in your best interest for him to like you alot.

i'm not sure if that would work with him, but i will give it some consideration.

"How he talks about his ex-girlfriend is how he will talk about you."

Word substitute accordingly. There's a reason it's a bad idea for candidates to bad-mouth their current employer, and it's the reverse of this situation.

So true. Best to stay clear of those kinds of people.

A general policy of mine is to avoid people who are frequently bad-mouthing other people. I think this is your key indicator of his character, and yes it does make for a hostile, and corrosive, work environment.

i am quickly adopting it as my general policy, too. i'm tired of the insecurity, neediness, and negativity that accompanies that mentality (along with the things you mentioned).

I regularly bad mouth people, but in an equal opportunity humorous way. Myself included.

Do what you like. Are you aware of the impression you give ofyourself when you badmouth others?