News for hackers. Stuff that matters.
Re:Why was "goto fail;" added without any other change to th... by stcredzero on Friday February 28, 2014 @11:30AM (#7319718)
It's just that the code had been around for years by that point, and given that, that's not the story the diff tells.
Re:Why was "goto fail;" added without any other change to th... by beachstartup on Friday February 28, 2014 @11:37AM (#7319781)
that's true but there are other, material changes in the file including conditional logic very close to the bug - to me that says there was at least some additional editing going on, giving opportunity to introduce an error.

if the entire diff was just + goto fail; that would be extremely suspicious, but that doesn't seem to be the case.