Re:Why was "goto fail;" added without any other change to th...
by stcredzero on Friday February 28, 2014 @11:30AM
(#7319718)
It's just that the code had been around for years by that point, and given that, that's not the story the diff tells.
Re:Why was "goto fail;" added without any other change to th...
by beachstartup on Friday February 28, 2014 @11:37AM
(#7319781)
that's true but there are other, material changes in the file including conditional logic very close to the bug - to me that says there was at least some additional editing going on, giving opportunity to introduce an error.
if the entire diff was just + goto fail; that would be extremely suspicious, but that doesn't seem to be the case.
he could have easily yanked a goto line 'yy' for use elsewhere or by accident and pasted it by accident with 'p' right after he yanked it.
i see two very similar lines, 49 and 53, which were probably copy/pasted and edited. it is completely reasonable to assume he accidentally did it with another line further down the file.
he could have refactored this code multiple times before re-committing this file, moving blocks around or editing lines. there's plenty of opportunity to introduce errors.
do you understand how editing works?