Re:Onion Terminal is a Web Browser Unix Terminal
by dmoreno on Friday December 20, 2013 @02:40PM
(#6943487)
Good eye. Patches are welcome. I will add right now these errors to the issue tracker, although caching if you are logged in (last link) is the standard behaviour: I dont think that if you change the password on the console you are inmediately logged out.
https://github.com/davidmoreno/onion/blob/master/src/onion/s...
The fact that in amongst the doc comment is "not really safe" should probably be a big red flag.
Then this happens:
https://github.com/davidmoreno/onion/blob/master/src/onion/s...
Not to mention that here:
https://github.com/davidmoreno/onion/blob/master/src/onion/h...
It'll just let you in if you can guess someone else's session.
Seriously. Systems ship with crypto API's. And uuid libraries.
USE THEM, FFS.