News for hackers. Stuff that matters.
Re:Onion Terminal is a Web Browser Unix Terminal by richo on Friday December 20, 2013 @02:37PM (#6943468)
Pretty much immediately I found a bug in his session generation:

https://github.com/davidmoreno/onion/blob/master/src/onion/s...

The fact that in amongst the doc comment is "not really safe" should probably be a big red flag.

Then this happens:

https://github.com/davidmoreno/onion/blob/master/src/onion/s...

Not to mention that here:

https://github.com/davidmoreno/onion/blob/master/src/onion/h...

It'll just let you in if you can guess someone else's session.

Seriously. Systems ship with crypto API's. And uuid libraries.

USE THEM, FFS.

Re:Onion Terminal is a Web Browser Unix Terminal by dmoreno on Friday December 20, 2013 @02:40PM (#6943487)
Good eye. Patches are welcome. I will add right now these errors to the issue tracker, although caching if you are logged in (last link) is the standard behaviour: I dont think that if you change the password on the console you are inmediately logged out.
Re:Onion Terminal is a Web Browser Unix Terminal by dmoreno on Friday December 20, 2013 @03:09PM (#6943649)
I just fixed at master the most important one, the first.
Re:Onion Terminal is a Web Browser Unix Terminal by richo on Friday December 20, 2013 @05:51PM (#6944650)
Your patch.. fixes.. one of the issues. Kinda.

I commented with a link to the CPRNG you should be using.