News for hackers. Stuff that matters.
Re:The Mozilla Developer Network has a New Face by riffraff on Monday December 09, 2013 @05:36PM (#6877571)
pardon me, but is that function writing to the database for each page view?
Re:The Mozilla Developer Network has a New Face by shabble on Monday December 09, 2013 @07:07PM (#6878038)
No, only views which hit a stale copy of the rendered page and have to call that render() function. Normal views would (I imagine, I haven't traced it back) use the get_rendered() instead, which checks that the cached version is current and schedules a re-rendering (which obviously requires DB writes anyway) if necessary.
Re:The Mozilla Developer Network has a New Face by handsomeransoms on Monday December 09, 2013 @06:01PM (#6877709)
Yeah - looks like it's emulating a lock so only one page can be rendered at a time (plus the overhead for database IO to maintain the lock). Is this really the best way to go about this?
Re:The Mozilla Developer Network has a New Face by shabble on Monday December 09, 2013 @07:09PM (#6878056)
Unless I'm missing something important, it's locking so the same page can only be rendering once at a time; if another request that would cause a rebuild comes in while a previous rebuild is still in progress, it gets bounced.
Re:The Mozilla Developer Network has a New Face by lmorchard on Tuesday December 10, 2013 @08:33AM (#6880575)
Yes, you are correct. We're trying to limit the system to one rendering per page at a time.
Re:The Mozilla Developer Network has a New Face by avidal on Monday December 09, 2013 @05:55PM (#6877684)
Seems to me it's actually writing to the database twice for each page view; once to update the render_started_at property on #845, and once again on #881.
Re:The Mozilla Developer Network has a New Face by lmorchard on Tuesday December 10, 2013 @08:34AM (#6880579)
That render() method is called only on page edits or forced refreshes, not on every page view.