Anti-Pattern: Iteratively Building a Collection Posted by shawndumas on Wednesday December 04, 2013 @12:47PM from the robots.thoughtbot.com dept. http://robots.thoughtbot.com/iteration-as-an-anti-pattern/ ( 2 comments | 9 points | on HN )
def signer_keys_and_uids signers.inject({}) do |result, signer| result.merge(signer.key_id => signer.uids) end end
builds not only one but two new hash objects on each iteration, while the "bad" code does neither. Array to Hash is probably best done using Hash[]
signers.map.with_object({}) { |signer, result| result[signer.key_id] = signer.uids }