News for hackers. Stuff that matters.
Re:To my friends in the Node community by dmourati on Saturday November 30, 2013 @02:29PM (#6824242)
Disagree. The fact that he initially rejected the PR then subsequently tried to revert another commit shows he was upset at being overruled.
Re:To my friends in the Node community by bdcravens on Saturday November 30, 2013 @02:46PM (#6824326)
I'll agree that the original PR was legit, and probably should have been merged.

However, if a rejected pull request can be overridden, then that pretty much rules out having PRs anyways. Perhaps Isaac should be able to merge his own PRs. If that's not the procedure, then it's not procedure.

Again, maybe I'm totally missing something here. I believe people are pissed because of the content of the commit that was rejected/reverted, but you have to separate that from what seems to be a run around the established policy.

Re:To my friends in the Node community by dmourati on Saturday November 30, 2013 @03:01PM (#6824386)
The very first comment shows the policy was adhered to. https://github.com/joyent/libuv/commit/804d40ee14dc0f82c482d...
Re:To my friends in the Node community by bdcravens on Saturday November 30, 2013 @03:17PM (#6824453)
Very true - I was a bit thrown off by the use of real name (Bert) in the explanation of the revert.