News for hackers. Stuff that matters.
Re:To my friends in the Node community by bdcravens on Saturday November 30, 2013 @02:10PM (#6824143)
Tough situation - I don't think bnoordhuis is trying to push a sexist agenda, but trying to enforce a workflow (at least as I'm reading it)
Re:To my friends in the Node community by ams6110 on Saturday November 30, 2013 @02:22PM (#6824207)
I agree. He rejected the original pull request on the grounds that it was "trivial." It didn't add anything new, didn't improve anything, and didn't correct any problem.

The then reverted the commit when procedures weren't followed (he had already rejected it).

Re:To my friends in the Node community by jaegerpicker on Saturday November 30, 2013 @02:55PM (#6824359)
His rejection and trivialization of the issue IS what people are upset about. Not the actual rejection. If he had rejected the commit, on grounds of procedure but offered a better neutral wording, or at least some way to improve the wording via another pr, then I don't believe anyone would have been upset. Instead he choose to make the gender inclusion matter trivial which is pretty close to just being plain divisive.
Re:To my friends in the Node community by dmourati on Saturday November 30, 2013 @02:29PM (#6824242)
Disagree. The fact that he initially rejected the PR then subsequently tried to revert another commit shows he was upset at being overruled.
Re:To my friends in the Node community by bdcravens on Saturday November 30, 2013 @02:46PM (#6824326)
I'll agree that the original PR was legit, and probably should have been merged.

However, if a rejected pull request can be overridden, then that pretty much rules out having PRs anyways. Perhaps Isaac should be able to merge his own PRs. If that's not the procedure, then it's not procedure.

Again, maybe I'm totally missing something here. I believe people are pissed because of the content of the commit that was rejected/reverted, but you have to separate that from what seems to be a run around the established policy.

Re:To my friends in the Node community by dmourati on Saturday November 30, 2013 @03:01PM (#6824386)
The very first comment shows the policy was adhered to. https://github.com/joyent/libuv/commit/804d40ee14dc0f82c482d...
Re:To my friends in the Node community by bdcravens on Saturday November 30, 2013 @03:17PM (#6824453)
Very true - I was a bit thrown off by the use of real name (Bert) in the explanation of the revert.