Google apps whitelist hardcoded into Chromium open source project

Re:Google apps whitelist hardcoded into Chromium open source... by mwill on Wednesday November 13, 2013 @03:02AM (#6723956)

Throwing some more info here, this is the NaCl whitelist, looks like it was originally added Feb last year [1]. There's a discussion on Chromium Code Reviews here [2], and an issue on the project itself here [3]

The original commit includes the comment 'We should remove this code when PNaCl ships' which got removed somewhere along the way.

[1] http://src.chromium.org/viewvc/chrome/trunk/src/chrome/rende...

[2] https://codereview.chromium.org/9368046

[3] https://code.google.com/p/chromium/issues/detail?id=113668

[ Parent | on HN ]

Re:Google apps whitelist hardcoded into Chromium open source... by paulirish on Wednesday November 13, 2013 @08:37AM (#6725045)

There was a brief discussion about this code on Twitter a few weeks back and I asked for extra clarification from engineering. Erik Kay explained on that bug ticket [3] a bit more:

"We don't enable NaCl on the web at large because we don't want to see a particular instruction set baked into the web. We enable it for apps that are in the Chrome Web Store (even hosted apps which are in the web) because it's a place where over time we can get developers to migrate to PNaCl. For this whitelist, we have similar controls to what we have on the Chrome Web Store, and our goal is to eventually remove the need for it altogether."

[ Parent | on HN ]

Re:Google apps whitelist hardcoded into Chromium open source... by mtrimpe on Wednesday November 13, 2013 @08:25AM (#6724992)

Does anybody know why (variations on copies of) leokun's comment are automatically marked as dead?

The comment seems perfectly valid so I can't figure out why that would happen...

[ Parent | on HN ]

Re:Google apps whitelist hardcoded into Chromium open source... by voltagex_ on Wednesday November 13, 2013 @08:33AM (#6725033)

The shortened link seems to do it.

[ Parent | on HN ]

Re:Google apps whitelist hardcoded into Chromium open source... by e40 on Wednesday November 13, 2013 @08:46AM (#6725088)

I believe it means his account has been banned, for some reason.

[ Parent | on HN ]

Re:Google apps whitelist hardcoded into Chromium open source... by Zoomla on Wednesday November 13, 2013 @10:53AM (#6725965)

I would be curious to find out who removed that comment 'We should remove this code when PNaCl ships'

[ Parent | on HN ]

Re:Google apps whitelist hardcoded into Chromium open source... by smussman on Wednesday November 13, 2013 @11:29AM (#6726276)

Looks like it was done in this commit: http://src.chromium.org/viewvc/chrome/trunk/src/chrome/rende...

[ Parent | on HN ]