I've spent a lot of time in academia myself. I was a TA in computer science and have taught undergrads so I was exposed to the political battles and stresses that go on. Perhaps I am misinterpreting what she is saying and she is really just speaking of dealing with all the BS that comes with working at a research university and the importance of teaching is a given. The part about writing out every day that she only has to be there for 7 years is a bit unsettling for a professor though. If I were a freshman CS student it wouldn't instill a lot of confidence that my professor wrote down that she was only going to have to be there for a set period of time in order to get amped up to come in and teach my class.
If you focus on the moment instead of "the future" you can respond to a student in the now, rather than reminding yourself that undergraduate research is essentially irrelevant to your tenure case so you should say no to this project. You can take a risk in your teaching and teach something you really care about instead of taking Prof Oldguy's advice to just teach the intro class from the same lecture notes as last year. You might take on that interesting, new, and risky interdisciplinary project with the guy from microbiology instead of reminding yourself that interdisciplinary projects are generally not reviewed well as people from neither discipline feel they have the expertise to look at them. Specialized projects are much safer.
You think that struggling for tenure makes people better teachers and better people; I think it makes people miserable. Yeah. Now you're that freshman CS student with a bitter overworked prof either trying not to cry or taking out latent hostility on students who is in it for tenure, instead of a happy, adventurous, intellectually interested prof. Big win!
No, this is the opposite of what I'm saying. I DON'T think it makes them better teachers. I think focusing on teaching makes people better teachers. I understand the realities of working at a large university where research is a major focus- again, I've worked in such an environment as an instructor myself. But let's not forget why universities exist in the first place. If you want to focus on research and getting grants and publications, that's great, but I believe you should at least have some interest in teaching. I'm not sure how effective a teacher you can be if you go into work every day reminding yourself that you only have to work there for a set period of time.
I agree with you to some extent about the interest in teaching, but be really honest: that's not what we're paying for. State support for education keeps going down, down, down, and government funders are the only funders who really give a crap about education of the students. They're not paying up anymore so that's not a priority, and people who prioritize teaching over research are out of a job. The same attitude is sneaking down to lower-ranked schools as well as they fight for revenue.
I love teaching and get good evaluations. It really means very little in the job market or retaining a tenure-track position. I'm glad you think that a "focus on research and getting grants and publications" is "great" because that is what you are evaluated on: if you can't do that then teaching is irrelevant.