News for hackers. Stuff that matters.
Re:Your test suite is trying to tell you something by lmm on Wednesday July 03, 2013 @10:39AM (#5984782)
The question is what's the cost/benefit on fixing such things? Not everyone is in a position to stop working on features for two days to track down something like this.

This particular bug is also a strong argument for using more advanced type systems, even if you have good test coverage.

Re:Your test suite is trying to tell you something by mooism2 on Wednesday July 03, 2013 @10:55AM (#5984907)
For something like this, you don't need an advanced type system. Even C can do

  struct duration { int in_nanoseconds; };
  struct duration seconds_duration (int in_seconds) {
    struct duration dt;
    dt.in_nanoseconds = in_seconds * 1000000000;
    return dt;
  }
  /*TODO: milliseconds_duration(), microseconds_duration(), etc */
Re:Your test suite is trying to tell you something by dllthomas on Wednesday July 03, 2013 @11:25AM (#5985132)
I highly recommend doing this kind of thing, incidentally. Just because two things have the same backing representation does not mean they're of the same type, and wrapping in a struct tells the compiler to keep them separate. It doesn't have any impact on performance; C structs don't carry anything more than their member and you've only got the one member. I do this with indexes and ids as well.
Re:Your test suite is trying to tell you something by gohrt on Wednesday July 03, 2013 @11:32AM (#5985189)
One would hope that 'typedef' would define a type in C, protecting the programmer from silent incorrect casts, but of course it doesn't, because C hates programmers.
Re:Your test suite is trying to tell you something by dllthomas on Wednesday July 03, 2013 @11:37AM (#5985234)
Well, typedef "defines a type", but (unfortunately) in a purely syntactic sense. If you're using typedef for something that's not wrapped in a struct or union, think hard about whether you mightn't want to also do that.
Re:Your test suite is trying to tell you something by jgrahamc on Wednesday July 03, 2013 @10:44AM (#5984825)
This particular bug is also a strong argument for using more advanced type systems, even if you have good test coverage.

Yes, it's a great pity that the compiler didn't say "You're multiplying a time.Duration by a time.Duration and expecting it to be a time.Duration".

Re:Your test suite is trying to tell you something by dllthomas on Wednesday July 03, 2013 @11:21AM (#5985094)
I'm not sure whether you're serious or not (and I see a few different jokes you could be getting at otherwise), but multiplying time by time should give you time squared, not time again. Unfortunately, even Haskell doesn't catch errors of that type if you want to use the ordinary mathematical operators, because (*) :: Num a => a -> a -> a.

In this case, that's not what's going on, though. It's multiplying time by unitless scaling factor, which doesn't present the same problem. However, there's a few ways you can get at the issue with the help of the language, you just have to distinguish between the different units you might be using to represent time - this doesn't really take an advanced type system: the example of having a .milliseconds method is along these lines.

Re:Your test suite is trying to tell you something by njs12345 on Wednesday July 03, 2013 @12:40PM (#5985712)
Have you seen the dimensional library? It's a slightly abusive use of the type system, but will check units at compile time. See e.g. http://code.google.com/p/dimensional/wiki/GMExample
Re:Your test suite is trying to tell you something by dllthomas on Wednesday July 03, 2013 @12:52PM (#5985816)
I think so; I've seen similar things, for sure. Obviously Haskell does have the ability to make this distinction; just (unfortunately) it's somewhat incompatible with the standard prelude, and thus common practice.
Re:Your test suite is trying to tell you something by straight_talk on Wednesday July 03, 2013 @07:48PM (#5988240)
The F# compiler does that.
Re:Your test suite is trying to tell you something by ghswa on Wednesday July 03, 2013 @08:00PM (#5988276)
For those that are interested, here's a link to the docs: http://msdn.microsoft.com/en-us/library/dd233243.aspx