Yes, exactly. And of course, there have been many examples of soldiers who were court-martialed for disobeying orders. The risk of disobeying is on the soldier -- they're taking their life in their hands when they make the decision to cross a superior. It's not as if the military says: "oh, you thought that order was illegal? We won't court-martial you, then."
The parent comment was totally specious, because Snowden is being treated exactly the way any soldier would be treated for a similar behavior. We don't just automatically pardon people for breaking laws because they broke laws with patriotic intent.
There is a reason we don't generally allow individuals to each individually determine what the Constitution does or does not mean.
There is a famous example in the military of an Army major (doctor) who refused to deploy to Afghanistan because he claimed it was unconstitutional.
You might think he was referring to the war, but instead he was referring to his Commander-in-Chief himself (Pres. Obama), who this major personally felt was a Muslim Kenyan who somehow managed to finagle himself into the Presidency.
It's hardly conclusive that what Snowden has revealed so far is even likely unconstitutional. It seems the most you can say is that the NSA is simply not being very nice at all to the rest of the world, but the Supreme Court decisions up to this point (including recent ones relating to Guantanamo's prison) have generally treated the rest of the world as not worthy of any but the most basic Constitutional protections.
However I've yet to see ANYONE in the mainstream press point out that the Obama administration was recently trying to pass legislation that reduced privacy protection for Americans as a response to the Chinese doing exactly what we are doing to the Chinese. There is a high level of hypocrisy here.
Call me an idealist, but my belief is that the USA as a country should take the moral high ground, even if it costs us tactically in the short run.
Of course that was before the NSA revelations revealed the true extent of the spying going on.
You are right that such cases are (and are meant to be) exceptionally rare. The U.S. Supreme Court gives exceptionally wide latitude in what counts as a lawful order, and as far as I know no servicemember has ever been tried (much less convicted) for following a valid order (even if they thought it was illegal).
But with that said I agree with your overall point that Snowden did break the law with at least some of his disclosures. If so much as one document he leaked was found to describe action that was legal (even if unethical) he would fall afoul of various U.S. laws protecting classified information.
Likewise, even if he leaked information describing activities found to be illegal, he may still get in trouble for not following Congress's approved route for such leaks (I'm not sure if that would be technically criminal or administrative in nature though).