News for hackers. Stuff that matters.
Re:Bug 698544 – Background configuration is missing in termi... by Jonanin on Saturday May 11, 2013 @12:55PM (#5691206)
A friend of mine works on gnome, and I asked him about it. The actual explanation for this is a lot more reasonable:

"Him: OK, I figured out what happened. It wasn't ideal in terms of commits. So, we have an old configuration system GConf, and we replaced it with our new one, GSettings, for N reasons. GSettings was missing a feature for gnome-terminal to implement, so it went without GSettings for a long time, until the 3.8 cycle, when we ported it over with a workaround. The port wasn't 100% complete, so it landed with the intention of adding feature parity, like with terminal transparency support.

However, after asking our team, we decided it wasn't worth it keeping the support code around for terminal transparency, and dropped it.

It's an unfortunate thing that happened where the reasoning wasn't relayed entirely in commit messages, and you're right -- it was dropped in a seemingly unrelated commit. But that's after intentions changed -- a broken port to new tech with the intention to fix it, then that changed, and thus it got dropped under the guise of "Remove dead code"

me: fair enough. so the only wrongdoing really was persch's response.

Him: Yeah. So, it turns out that he was just tired. That was the 7th or 8th bug report about it, and he didn't feel like explaining it again."

Re:Bug 698544 – Background configuration is missing in termi... by farmdawgnation on Saturday May 11, 2013 @01:30PM (#5691328)
So, the moral of this story is "communicate clearly the first time or you're going to end up having to communicate clearly about seven or eight times."

That said, I don't understand why he felt he had to keep explaining it. He could have just copied and pasted the answer or closed the bug as a duplicate of the original one that reported the bug. In the original he could have posted a kind explanation about it, and linked to it from the duplicates that followed.

I understand what it's like to get tired and short tempered. I used to moderate an online community primarily of middle schoolers and high schoolers. But ultimately, you end up hurting the community you're supporting more by not doing things The Right Way™ the first time around. You hurt it even further when you fail to acknowledge that you're tired, short tempered, and should probably just go to bed and deal with it in the morning.

Maybe I just expect adults to behave like adults, but "he didn't feel like explaining it again" doesn't float with me as a valid justification for how he handled the issue. It would have taken a comment and a link to deal with it the correct way. Live and learn, sure, but the attitude reflected in his response appears (to me, at least, with my limited visibility) to be reflective of a systemic attitude surrounding GNOME development. And that's no good.

Re:Bug 698544 – Background configuration is missing in termi... by mpyne on Saturday May 11, 2013 @03:14PM (#5691755)
I was going to recommend "closing as a dupe" as well. One nice thing about that is it makes it very easy to see which bugs are causing anguish with the users.

Also it makes it clear which single point of discussion contains the rationale for the changes so that the developer doesn't have to re-explain (something to which I'm sensitive myself, having been on the dev end of changes like this).

Re:Bug 698544 – Background configuration is missing in termi... by vacri on Sunday May 12, 2013 @01:26AM (#5693262)
Close-as-duplicate is the right answer, though there's a special place in hell for people who close-as-dupe without referring to which ticket is the dupe. In my previous role as a software tester, there'd be all sorts of tickets closed-as-dupe, yet I couldn't find them. Turns out that they had no common search terms and were (usually) not actually dupes, just that the coders didn't want to think too hard on the issue. I'm fine with "won't fix" or pushing to backlog, but let me see what the dupe is.
Re:Bug 698544 – Background configuration is missing in termi... by azernik on Sunday May 12, 2013 @07:36PM (#5696373)
I'm mostly used to the equivalent functionality in Launchpad, but my impression is that most bug trackers have a special "duplicate of bug N" closing reason that requires a link to another bug.
Re:Bug 698544 – Background configuration is missing in termi... by pgroves on Saturday May 11, 2013 @02:33PM (#5691564)
I just searched for a few different mutations of the phrase "background transparency" in their bugzilla and didn't see any. I was expecting this to be a case of an end user not taking the time to see if their issue was already in the bug tracker, but if it's in there, it's hard to find. If there were really multiple bug reports (which I'm not saying there weren't) then bugzilla has a pretty bad search feature.

It's a pretty big problem when bug trackers are exposed to a group of non-technical users. Stackoverflow has a nice feature where it does a real time search of existing questions as you type yours in to prevent duplicates. I wish that was a considered a must-have feature of bug trackers.

Re:Bug 698544 – Background configuration is missing in termi... by towolf on Saturday May 11, 2013 @02:41PM (#5691611)
You have to use an advanced search to find NOTABUG, WONTFIX, and DUPLICATE and similar bugs. Otherwise you turn up empty. There’s even more discussion in the other bugs. For some reason they didn’t dup all those bugs consistently. Maybe that would’ve lead to a criticla mass. But who knows why not.

[List of bugs mentioning problems related to background transparency](https://bugzilla.gnome.org/buglist.cgi?product=gnome-termina...)

Re:Bug 698544 – Background configuration is missing in termi... by chris_wot on Saturday May 11, 2013 @06:28PM (#5692340)
So if it's a duplicate bug report, mark it as such. Do just type in "No." as your answer and close as WONTFIX. Point the reporter back to the original bug!

How is that hard to do?

Re:Bug 698544 – Background configuration is missing in termi... by GhotiFish on Sunday May 12, 2013 @08:53AM (#5694073)
You might be surprised what's hard to do, depending on what condition you happen to be in.
Re:Bug 698544 – Background configuration is missing in termi... by mratzloff on Sunday May 12, 2013 @11:38AM (#5694627)
For example, you might have a gunshot wound and are trying to make a tourniquet while you type. Did you ever consider that?
Re:Bug 698544 – Background configuration is missing in termi... by GhotiFish on Sunday May 12, 2013 @11:48AM (#5694671)
Or you could be trying to thread a needle while overdosing on PCP.

The possibilities are endless! :D

Re:Bug 698544 – Background configuration is missing in termi... by Dylan16807 on Saturday May 11, 2013 @01:40PM (#5691350)
I find it interesting that you use the word 'guise' in a post defending the code removal. There is still no explanation for the removal except for "wasn't worth it", which is pretty lacking by itself.

And the way you resolve a repeated bug report is to link it to the last one and close-duplicate. You don't even need to respond at all.

In short: What you've explained is more reasonable but it's still opaque and unhelpful; someone involved should summarize why it was removed and if it could be rewritten and put back in.

Re:Bug 698544 – Background configuration is missing in termi... by Jasper_ on Saturday May 11, 2013 @01:55PM (#5691400)
I'm that friend. I said to Jonanin: "If you want to know exactly, it's a lot of very, very tricky code that's easy to get wrong, hard to get right, and even when it looks like it's working, there's a large perf cost if it's not 100% right.", but it seems he didn't paste that part of the chatlog.

I can't speak for why Christian Perch spoke the way he did, but he knows that he shouldn't do it anymore.

So, let's go into more details. There are a few ways to get real transparency for windows under X.

First of all, there's _NET_WM_OPACITY which is handled by the compositor window manager, and that's the replacement workaround suggested, but some think it's not appropriate enough. Fine.

Second, there's "psuedotransparency", which is expensive on a modern system. Basically, you copy parts of the root window, excluding your window, and then paint it under your window. Every time some other window updates, you need to re-fetch contents. This is wasteful, but it's how transparent terminals were implemented in the 80s. To implement it, there's a bunch of MMX (yes, MMX) code that's been copy/pasted to every project. The only existing program that uses pseudotransparency that's still maintained is XChat/HexChat.

Third, there's RGBA visuals, which require a compositing window manager. The issue here is that the RGBA visual isn't always around: it's dependent on your window being redirected to an off-screen pixmap. If the compositing WM restarts, or you close down the compositing WM and start up a traditional WM, or close down the traditional WM and start up a compositing WM, you have to basically close your window and re-open it. This is racy and bad to do at WM startup time, and accounts for a few bugs/crashes in the WM or in gnome-terminal. Furthermore, closing and restarting the window means that the new window is now on top of the stack whenever you restart the WM.

It's really ugly behavior all around, and we did an informal poll and found that almost nobody was using transparent terminals, and decided to drop the code.

X just isn't meant for modern graphics.

Re:Bug 698544 – Background configuration is missing in termi... by pyre on Saturday May 11, 2013 @02:13PM (#5691486)

  | First of all, there's _NET_WM_OPACITY which is
  | handled by the compositor window manager, and that's
  | the replacement workaround suggested, but some
  | think it's not appropriate enough. Fine.
This is the part that I don't understand. The whole point of 'terminal transparency' is to make the background transparent while leaving the text opaque. This 'workaround' makes everything transparent, which defeats the purpose of leaving the text readable.

I don't personally use terminal transparency, but it does not seem logical that someone could see _NET_WM_OPACITY as a replacement for this. This seems like a really weak (and poorly thought out) attempt to 'throw a bone' to the people that want the feature that's being removed.

  Sure, we're removing the NY strip steak from our menu,
  but there's always the hamburger, that has beef in it
  too. You can even add steaksauce to the burger!
Re:Bug 698544 – Background configuration is missing in termi... by Jasper_ on Sunday May 12, 2013 @12:05AM (#5693102)
I didn't think that through 100%. You're absolutely right.
Re:Bug 698544 – Background configuration is missing in termi... by towolf on Saturday May 11, 2013 @02:09PM (#5691469)
By the way. Ubuntu was using transparent background by default [1].

So it’s fair to say that at bare minimum tens of thousands of people were using this code path.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=692609#c2

Re:Bug 698544 – Background configuration is missing in termi... by stuaxo on Saturday May 11, 2013 @03:44PM (#5691862)
I think it would be reasonable to start requiring a compositor for transparency, if it simplifies the code.

That way we can have our cake and eat it - most of the time if you don't have a compositor then transparency doesn't make sense anyway (performance is terrible) - instances include VNC.

I'd certainly be happy with this solution.

(Speaking as a transparent gnome terminal user).

Re:Bug 698544 – Background configuration is missing in termi... by mpyne on Saturday May 11, 2013 @06:23PM (#5692324)
That's what we did with Konsole for KDE 4. KWin integrated compositing with a software fallback in case GL wasn't available, so there was simply no need to maintain the KDE 3.5-era fake transparency.

Nowadays GNOME Shell simply requires a compositor, or so I thought, so it seems like you could assume one is present.

The one issue is supporting the case of running gnome-terminal from non-GNOME environments that also don't have a compositor, but I think it would be fair to give up entirely on supporting that use case.

However you might still want to handle the case of the compositor crashing (I think one of the dev's comments in this thread mentioned that), which is admittedly going to be annoying since it involves dealing with X.

Re:Bug 698544 – Background configuration is missing in termi... by Jasper_ on Sunday May 12, 2013 @12:08AM (#5693107)
We'd love to do that, but sometimes it doesn't work that way. If you restart the compositor, in order to not crash, you need to unmap and remap your window with a different visual. So the code needs to be there anywhere if your compositor WM doesn't crash.
Re:Bug 698544 – Background configuration is missing in termi... by towolf on Sunday May 12, 2013 @08:40AM (#5694047)
From what I’ve read on another bug from 2011 ARGB Visual could also just stay on even without a compositor.
Re:Bug 698544 – Background configuration is missing in termi... by towolf on Saturday May 11, 2013 @02:08PM (#5691458)
You forgot to mention that the ARGB Visual type was working well enough for years, ever since xcompmgr was around, all trough compiz and GS.

And the GS → metacity → GS cycle was not crashy here at all. It worked.

And now you’re getting into Wayland territory. All the more reason to make sure that windows with alpha maps work.

You can keep the old code around in the meantime.

Also, making a poll in your 50 people IRC channel is not a very meaningful sample size is it?

Re:Bug 698544 – Background configuration is missing in termi... by pyre on Saturday May 11, 2013 @02:41PM (#5691607)

  | Also, making a poll in your 50 people IRC channel
  | is not a very meaningful sample size is it?
They just polled the IRC channel? Really? That just seems like the definition of a 'circle jerk.' Was the assumption that all or a majority of users technical enough to use the terminal would be in the IRC channel?
Re:Bug 698544 – Background configuration is missing in termi... by towolf on Saturday May 11, 2013 @02:50PM (#5691643)
> Really?

No idea. That’s what I derive from "we had an informal poll". Since they hang out on IRC that is probably where it happened.

Re:Bug 698544 – Background configuration is missing in termi... by Jasper_ on Saturday May 11, 2013 @03:00PM (#5691690)
The old code didn't work after the port to GSettings. It crashed in weird places. That's why it was "#if 0"'d around in the GSettings port commit. As I said, the original intention was to fix it, but minds were changed.
Re:Bug 698544 – Background configuration is missing in termi... by towolf on Saturday May 11, 2013 @03:05PM (#5691713)
> but minds were changed.

So what does it take to make the minds change back again?

When I stare at opaque terminals all day I get severely perceptually understimulated to the point that I fear becoming an automaton.

But with some sliding animations and a bit of flower poking through it soothes my nerves.

Is that not enough reason?

Re:Bug 698544 – Background configuration is missing in termi... by towolf on Saturday May 11, 2013 @03:06PM (#5691717)
I can’t see how Gsettings has anything to do with opacity and the compositor.

Perhaps separating these things out in different commits would’ve been smarter to begin with.

Re:Bug 698544 – Background configuration is missing in termi... by Jasper_ on Sunday May 12, 2013 @12:11AM (#5693115)
With hindsight, yes, we'd love to do things differently. Saying "you should have done" doesn't really help the current situation here.

The gsettings port broke stuff and reintroduced problems. It was long overdue. This means that cutting features to get things out of the door might happen.

If I had to guess without debugging, I might guess that the 'changed' signals were firing at different times in comparison to when the slider was being adjusted that means that changing the background wasn't ordered 100% correct. The code stems back to 1996 -- it's possible that assumptions like these are being made.

Re:Bug 698544 – Background configuration is missing in termi... by jodrellblank on Saturday May 11, 2013 @04:03PM (#5691913)
I can’t see how Gsettings has anything to do with opacity and the compositor.

You are implying that because you don't know about the connection, there must not be one?

Perhaps separating these things out in different commits would’ve been smarter to begin with.

20/20 hindsight criticism from someone watching from the sidelines? Helpful.

Re:Bug 698544 – Background configuration is missing in termi... by towolf on Saturday May 11, 2013 @04:11PM (#5691942)
Only looking for explanations. Really super grateful that Jasper_ added some, but it’s still not entirely clear.
Re:Bug 698544 – Background configuration is missing in termi... by chris_wot on Saturday May 11, 2013 @06:33PM (#5692354)
Your "informal poll" evidently didn't include the userbase.
Re:Bug 698544 – Background configuration is missing in termi... by keenerd on Monday May 13, 2013 @06:49AM (#5698012)
> However, after asking our team, we decided it wasn't worth it keeping the support code around for terminal transparency, and dropped it.

Um, isn't this all handled by VTE?

And as a Gnome project, does this mean transparency will eventually be removed from VTE? I know of about 20 VTE-derived terminals that will not be pleased to hear this.