News for hackers. Stuff that matters.

A comment on PostgreSQL 9.2.4, 9.1.9, 9.0.13 and 8.4.17 released. Parent comment

Re:PostgreSQL 9.2.4, 9.1.9, 9.0.13 and 8.4.17 released by themckman on Thursday April 04, 2013 @10:59AM (#5493023)
That is a fantastic commit message. I try and convince anyone I work with that they should write commit messages like this. Slowly, but surely, they come around.
[ Parent | on HN ]
Re:PostgreSQL 9.2.4, 9.1.9, 9.0.13 and 8.4.17 released by sickpig on Thursday April 04, 2013 @11:23AM (#5493172)
And the author is a fantastic coder/developer, really!

https://en.wikipedia.org/wiki/Tom_Lane_%28computer_scientist...

[ Parent | on HN ]
Re:PostgreSQL 9.2.4, 9.1.9, 9.0.13 and 8.4.17 released by drbawb on Thursday April 04, 2013 @12:16PM (#5493453)
What gets me about Tom Lane is that he's _so active_ on the mailing list(s).

It seems that every time I search the archives regarding an issue I'm having: I find a reply authored by Tom Lane.

[ Parent | on HN ]
Re:PostgreSQL 9.2.4, 9.1.9, 9.0.13 and 8.4.17 released by joevandyk on Thursday April 04, 2013 @11:53AM (#5493335)
Tom committed the fix, he didn't author it.
[ Parent | on HN ]
Re:PostgreSQL 9.2.4, 9.1.9, 9.0.13 and 8.4.17 released by mkopinsky on Thursday April 04, 2013 @12:10PM (#5493422)
Who writes commit messages for these kinds of user-submitted patches? The author or the committer?
[ Parent | on HN ]
Re:PostgreSQL 9.2.4, 9.1.9, 9.0.13 and 8.4.17 released by selenamarie on Thursday April 04, 2013 @01:25PM (#5493858)
Generally the committer writes the commit message. There is occassionally discussion of specific wording ahead of time.
[ Parent | on HN ]
Re:PostgreSQL 9.2.4, 9.1.9, 9.0.13 and 8.4.17 released by jeltz on Thursday April 04, 2013 @01:24PM (#5493848)
Usually the committer. Most patches sent to the mailing list does not contain a commit message.
[ Parent | on HN ]
Re:PostgreSQL 9.2.4, 9.1.9, 9.0.13 and 8.4.17 released by weaksauce on Thursday April 04, 2013 @12:08PM (#5493419)
The author of the commit message I think is what the op was implying.
[ Parent | on HN ]
Re:PostgreSQL 9.2.4, 9.1.9, 9.0.13 and 8.4.17 released by sickpig on Thursday April 04, 2013 @12:31PM (#5493544)
Yep this is what I meant. I could have chosen my words in a better way though, since we were talking about a git commit. Having said that quoting commit message 2nd last paragraph:

The Postgres project thanks Mitsumasa Kondo for discovering this bug, Kyotaro Horiguchi for drafting the fix, and Noah Misch for recognizing the full extent of the danger.

We can't exclude without further info that Tom contributed to the fix, just saying.

Knowing him after a few years spent following postgres dev process I bet on co-authoring at least :)

[ Parent | on HN ]