News for hackers. Stuff that matters.
Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by dmix on Wednesday January 02, 2013 @05:07PM (#4999612)
I've always found Rails to be easy to secure compared to most other frameworks.

I think the defaults are all pretty secure.

I'd prefer having constant security patches. It shows people are still constantly testing it for vulnerabilities.

Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by revelation on Wednesday January 02, 2013 @05:32PM (#4999734)
SQL injection is the web-equivalent of having a stack allocated buffer overflow. We have built and use (expensive) abstractions that supposedly eliminate these whole class of issues.

With Rails, you get the expensive abstraction and apparently none of the security.

Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by tptacek on Wednesday January 02, 2013 @11:31PM (#5001030)
This is silly. The stinger on this vulnerability is SQL injection, but the vulnerability itself is closer in spirit to code injection. The issue here isn't database hygiene. Parameterized queries would not have helped.

There's a real critique of Rails to be leveled here (there is some fucked up stuff going on with Rails request processing), but yours isn't it.

Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by phillmv on Wednesday January 02, 2013 @06:34PM (#5000054)
Yes, clearly, because Rails has introduced absolutely no other kind of default protection.

Is this an argument for hand rolling your own code, or for using some other framework that is apparently immune (or, to be charitable, has a stronger security track record)?

Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by srdev on Wednesday January 02, 2013 @07:06PM (#5000196)
Likely its an argument to use parameterized queries which fix the SQL injection problem altogether. I'm not familiar with Ruby, but surely they support it in 2013?
Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by numbsafari on Friday January 04, 2013 @12:18AM (#5006380)
NB: what I'm about to write isn't specific to ActiveRecord, it's about SQL injection in general. So please, don't read this thinking I'm making specific claims about AR. I'm just responding to one part of the above claim.

Anyhow...

Parameterized queries do not "fix the SQL injection problem altogether". They solve the most common issue where someone is simply building up a full SQL statement and passing user inputs as part of the string (not as parameters). I call that "Class 1" SQL injection problem. You find this a lot in hand-rolled web apps (especially PHP apps since the legacy MySQL library hasn't been snipped out yet and most tutorials explicitly tell you to do this, even though PHP has long supported parametric SQL).

However, many DB access libraries and ORMs offer facilities that generally revolve around the desire to allow the client application to customize or optimize the generated SQL created by the library (or bypass the SQL generation but leverage the library managed connection state). The API typically just trusts that you know what you are doing, blindly accepts the SQL you give it and injects it into (or replaces) whatever it generated on its own. These are the source of what I call those Class 2 injection vulnerabilities. That is, SQL gets injected in what cannot otherwise be parameterized. These can be mitigated by running a sanity check on the full SQL before it goes to the server (for example, searching it for comment strings and raising and exception or returning an error if they are detected). They can also be detected by scanning your query logs for the same things. Also, this is typically caused by a bug in your code, not the library, since it was trusting you to give it clean SQL.

Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by qxcv on Wednesday January 02, 2013 @08:01PM (#5000434)
They do, but what we're talking about here is an ORM, so there will always be machine generated SQL somewhere. Or do you believe that GP is suggesting that developers use parameterised SQL queries instead of an ORM?
Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by untog on Wednesday January 02, 2013 @08:04PM (#5000449)
Er, why can't the ORM use paramaterised queries?
Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by jeltz on Wednesday January 02, 2013 @08:44PM (#5000615)
The problem is that ORMs like ActiveRecord really are just domain specific languages for building queries. If these DSLs use inband are carelessly constructed (e.g. they use some form of inband signaling) you can do the injection attack against the actual ORM code and make it build queries the author of the code did not intend.
Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by sontek on Wednesday January 02, 2013 @09:36PM (#5000775)
http://sqlalchemy.org/ is an ORM and does not have these security issues. So it can be done.
Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by qxcv on Thursday January 03, 2013 @04:05AM (#5001518)
Searching for "sqlalchemy sql injection" brings up this: https://bugzilla.redhat.com/show_bug.cgi?id=783305
Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by jeltz on Wednesday January 02, 2013 @10:25PM (#5000896)
I did not say otherwise. I said that ORMs may be vulnerable if they are carelessly constructed.
Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by mds_ on Wednesday January 02, 2013 @11:28PM (#5001021)
Actually, no, not if you're using the mysql2 gem. There is an open issue / pull request but it doesn't seem to have much momentum.

https://github.com/brianmario/mysql2/pull/289

Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by wglb on Thursday January 03, 2013 @07:37AM (#5002053)
I am not sure I think of abstractions as featuring improved security. I recently did an (internal to client) blog post about the job of a penetration tester as "puncturer of abstractions". I do have permission to publish it publicly, so I plan to do so.

But briefly, if you think of a grammar such as HTML in terms of an abstraction, the very fact that you need to encode output when creating HTML indicates that the abstraction can be "punctured".

And many abstractions, such as stored procedures, don't help you out at all. There is a oft-repeated untruth that somehow stored procedures magically prevent SQLi.

Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by biot on Wednesday January 02, 2013 @05:18PM (#4999660)
That's a false dichotomy. I'd prefer to have people constantly test something for security vulnerabilities and find nothing because the code was thoroughly audited and shown to be secure before it was released.
Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by ssmoot on Wednesday January 02, 2013 @06:25PM (#5000003)
That's a leap. Yehuda and I knew about the mass-assignment vulnerability during DataMapper v0.3, way back in the Merb days, before Rails3.

Yet it didn't get addressed until a few months ago.

PS: It's still broken IMO. It needed a rethinking of strategy and purpose. Instead it got a quick hack. If you want to see mass-assignment done right, look to Play Framework's First Class Forms support.

Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by steveklabnik on Wednesday January 02, 2013 @10:11PM (#5000851)
Mass assignment as a feature is completely removed from Rails 4, and a gem with the replacement (strong_parameters) is available _today_ for you to use with any 3.x application.
Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by VMG on Wednesday January 02, 2013 @05:18PM (#4999665)
by that logic php is rock solid
Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by ojr on Wednesday January 02, 2013 @06:55PM (#5000146)
75% of web servers run on it, I think thats a pretty solid mark
Re:SQL Injection Vulnerability in Ruby on Rails; affects all... by reinhardt on Wednesday January 02, 2013 @07:15PM (#5000241)
Not when the 66% of them get 0wned