Just like everything else in life the system would be subject to the laws of thermodynamics. The act of pressurising air would heat it up, and heat loss would mean that it wouldn't be fully reversible.

I suspect that a fully evacuated system using magnetic propulsion and energy recovery would be more efficient - the turbulent nature of air and the low-quality nature of heat energy would probably work against you to make a pneumatic spring fairly inefficient.