News for hackers. Stuff that matters.
Re:"Giving up upstream-ing my patches & feel free to pick th... by SOLAR_FIELDS on Saturday January 31, 2026 @04:43PM (#46841179)
Your first example should be solved by the maintainers outlining clear contribution guidelines. It’s not hard to point some automation at a pr and comment if someone didn’t follow contribution guidelines.

Nonmatching styles can be mostly solved with linting and static analysis

There’s no fix for bad code outside of manual review beyond that. But doing those things should significantly cut down on your noise.

Re:"Giving up upstream-ing my patches & feel free to pick th... by pousada on Saturday January 31, 2026 @04:53PM (#46841270)
Trust me it’s not being solved by a CONTRIBUTING.md with guidelines.

90% of contributors won’t read it at all or only some parts of it and ignore the rest.

Most PRs you get solve some super specific individual problem and aren’t relevant for the wider community that uses your OSS.

It’s not their fault really but most contributions are so bad it doesn’t serve to spend any time on reviewing them earnestly.

(Been maintaining several popular projects for the last 7 years)

Re:"Giving up upstream-ing my patches & feel free to pick th... by judahmeek on Saturday January 31, 2026 @05:32PM (#46841582)
Can I get your opinion on https://github.com/Judahmeek/frogs as an open-source maintainer?

Edit: https://judahmeek.com/p/we-need-frogs-to-defend-foss may be the better link to start with.

Re:"Giving up upstream-ing my patches & feel free to pick th... by pousada on Sunday February 01, 2026 @09:29AM (#46846451)
I don’t think there is a simple “fits-all” solution.

In my case there is a monetised proprietary “enterprise” edition of the projects available. Contributions only get accepted if they fit into the commercial roadmap, which is shaped by the (paying) customer needs.

It’s not perfect but the OSS “community” edition is still usable and valuable to many

Re:"Giving up upstream-ing my patches & feel free to pick th... by judahmeek on Monday February 02, 2026 @01:12AM (#46852978)
Thanks for taking the time to reply. I agree that there's no "fits-all" solution & I think that's a good sign of the open-source ecosystem's diversity.
Re:"Giving up upstream-ing my patches & feel free to pick th... by socalgal2 on Saturday January 31, 2026 @11:20PM (#46843577)
I haven't seen static analyis cover the things I'm concerned with.

Examples, calculating something twice instead of pulling the calculation out of the loop (one case) or into a separate function so that 2 separated places where it's calculated don't get out of sync (a different case). Another might be using an let x; if (cond) x = v1 else x = v2 (which is 3-9 lines depending on your brace style) vs const x = cond ? v1 : v2. When v1 and v2 are relatively simple expressons. I haven't seen a checker that will find stuff like this.

Re:"Giving up upstream-ing my patches & feel free to pick th... by mirekrusin on Sunday February 01, 2026 @05:50AM (#46845209)
If just close pr without explanation. In contributing guidelines I’d mention that low quality prs will be closed as they waste time and "why was it closed without explanation?" won’t be answered either because it would waste time and the whole point is not to.
Re:"Giving up upstream-ing my patches & feel free to pick th... by lelanthran on Sunday February 01, 2026 @03:15AM (#46844469)
> Nonmatching styles can be mostly solved with linting and static analysis

Only syntactical styles. Style also include things like how I want errors to be propagated, how failures are to be handled, etc.