Re:Your job is to deliver code you have proven to work
by hoten on Thursday December 18, 2025 @03:13PM
(#46318018)
I think the point is that a necessary part of being careful is reviewing the diff yourself end-to-end right before sending it out for review. That catches mistakes like these.
Re:Your job is to deliver code you have proven to work
by code_for_monkey on Thursday December 18, 2025 @04:47PM
(#46319250)
i myself have been guilty of creating a pr and immediately pushing a commit to clean that stuff up
That’s not a great example of lack of care, of you use code formatters then this can happen very easily and be overlooked in a big change. It’s also really low stakes, I’m frankly concerned that you care so much about this that you’d label a dev careless over it. I’d label someone careless who didn’t test every branch of their code and left a nil pointer error or something, but missing formatter changes seems like a very human mistake for someone who was still careful about the actual code they wrote.