News for hackers. Stuff that matters.
Re:The Theatre of Pull Requests and Code Review by siva7 on Thursday September 25, 2025 @05:13PM (#45379164)
I've met thousands of developers over my career and i could put them into two categories: those who don't give a shit about intermediate commit messages (majority) and those who browse every single intermediate commit message in a PR (very few). To be honest, the latter had some tendency to be difficult to work with. It was also a useful discriminator to avoid getting those into my teams.
Re:The Theatre of Pull Requests and Code Review by phatskat on Friday September 26, 2025 @12:15PM (#45388145)
I tend to read intermediate commits because it can be helpful in understanding how the engineer thought through developing the feature. This is especially informative when reviewing more junior/mid-level code, or when a feature grows beyond what I would consider acceptable scope - obviously, avoiding these kinds of branches is the ideal state, and unfortunately the realty doesn’t let me always push back for smaller PRs.