News for hackers. Stuff that matters.
Re:The Theatre of Pull Requests and Code Review by fillmore on Thursday September 25, 2025 @01:17PM (#45375772)
Replying to echo this, I also read every commit message, and review PRs commit by commit. This was common practice at my last job (a small, experienced team), and the expectation was that commits were atomic.

Yes, we griped that GitHub would not allow us to merge individual commits, but if it was ever urgent or helpful to do so, we cherry-picked a commit into a separate PR.

Everyone's workflow is a bit different, and it can be hard to redirect organizational inertia. But without a doubt, reading a clean commit history is a pleasure.

Re:The Theatre of Pull Requests and Code Review by Freedom2 on Thursday September 25, 2025 @11:40PM (#45382374)
Thank you for this! I find it disturbing that the original-original poster extrapolated their experience to the rest of us as if it were a fact.