News for hackers. Stuff that matters.
Re:Recreating the US/* time zone situation by machinate on Sunday September 14, 2025 @06:28PM (#45243917)
What issue are you taking with the code? Line breaks in the condition?

Presumably the last if statement in the diff.

Re:Recreating the US/* time zone situation by azinman2 on Sunday September 14, 2025 @07:12PM (#45244257)
There aren’t {} brackets after the if
Re:Recreating the US/* time zone situation by machinate on Sunday September 14, 2025 @07:47PM (#45244514)
Are you saying they should always be present? Or only when the condition takes multiple lines; i.e. do you take issue with the ifs in zone_name_pref too?

Personally I think the indentation does a good enough job here.

Re:Recreating the US/* time zone situation by azinman2 on Monday September 15, 2025 @10:23AM (#45250112)
Yes I’m saying they should always be present. It is known to otherwise be error prone, which is why new c-like languages do not permit this (eg go) nor do many style guides (https://google.github.io/styleguide/cppguide.html#Formatting...)