Giving feedback is always better in person I find, mainly because giving feedback in person (not to be mistaken with criticism) allows you to have a fluid conversation, your boss will also appreciate it more, you show you really care and you have the balls to go up to him. People get promoted that way. It's just more "relaxed" and your boss will take it more serious.