News for hackers. Stuff that matters.
Re:Show HN: A portable hash map in C by zabzonk on Sunday December 08, 2024 @04:36PM (#42360759)
OK, thank you. But why do the functions have those unused parameters?
Re:Show HN: A portable hash map in C by Sesse__ on Sunday December 08, 2024 @04:39PM (#42360783)
I would assume that is because the hash table takes in a “hash this key” function pointer and a “compare these keys” function pointer, and those must contain the size for variable-length keys. So even if your user-supplied functions know the length, or only care about the first byte, they have to conform to that API, and then you get an unused parameter.
Re:Show HN: A portable hash map in C by zabzonk on Sunday December 08, 2024 @04:42PM (#42360829)
Have functions with different names and different numbers of parameters?
Re:Show HN: A portable hash map in C by Sesse__ on Sunday December 08, 2024 @04:47PM (#42360880)
And then have a union between the two different kinds of pointers, and a tag to tell which one is in use, then test that tag everywhere? Why? What good does it bring for that extra complexity?
Re:Show HN: A portable hash map in C by zabzonk on Sunday December 08, 2024 @04:57PM (#42360985)
Doesn't the name of the function select for the types and use of the parameters? But I haven't written in C for a long time, and this I think could be done more clearly in C++.
Re:Show HN: A portable hash map in C by Sesse__ on Monday December 09, 2024 @12:38PM (#42368301)
You're saying you would write the entire hash table four times, with everything duplicated and no reuse? Again: Why? What do you gain compared to one line to suppress a warning?
Re:Show HN: A portable hash map in C by zabzonk on Monday December 09, 2024 @05:19PM (#42371182)
Clarity? And in C++ at least, I would re-write the functions.
Re:Show HN: A portable hash map in C by detaro on Sunday December 08, 2024 @06:04PM (#42361515)
The point is that you can pass any of the hash functions (or your own compatible) to the datastructure, so it'll obviously call of them with the same set of parameters. And hash functions that need all of them will ignore them.
Re:Show HN: A portable hash map in C by saagarjha on Sunday December 08, 2024 @04:49PM (#42360901)
That would be a bad API design.