PR Process Is Killing Morale and Productivity

Re:PR Process Is Killing Morale and Productivity by simmschi on Friday November 29, 2024 @12:50PM (#42275582)

Have you tried the code owners feature (assuming you're on Github).

IMO a good approach is to have the actual code owners (i.e. the team responsible for a specific service or library) review the PR. If they think a shallow LGTM review of 3k LOC is enough, they can also deal with the bugs :-)

If you don't have specific ownership in your code base I'd start there.

[ Parent | on HN ]

Re:PR Process Is Killing Morale and Productivity by donatj on Friday November 29, 2024 @12:57PM (#42275653)

This is all within a relatively small single team.

As I said however, I could require review from specific people I know review but they're already at their wits end.

Also having to explain why certain devs are required without it smelling like some sort of favoritism seems fraught.

[ Parent | on HN ]

Re:PR Process Is Killing Morale and Productivity by Aeolun on Saturday November 30, 2024 @03:12PM (#42283734)

Normally you promote those people to ‘senior’ and then say that a review by at least one senior is required?

[ Parent | on HN ]