Re:Did my coding lead to colleague's death?
by deanmoriarty on Sunday November 17, 2024 @11:08AM
(#42164900)
I will say that code reviews with some individuals have been, by far, the most stressful and demotivating part of my job, and a major reason why I am looking to end a career in developing software in teams.
This is especially true in companies with a heavy culture of code reviews, and can be terrifying when a new team member joins and you are waiting for them to reveal what their review style is going to be.
Many times it’s an exhausting “I know my code works, I know my code is fairly robust to the current challenges we are facing, I know it is well readable and commented, and yet you are shitting on it so much that if we weren’t paid to be here I would straight up just tell you to go fuck off”.
In a particular team I worked at Google, it was common to see for fairly small and reasonable PRs (100-500 LOC range including tests) get ~50 or more comments by many people, including opinionated ones. The irony was that many times the comments left by people were directly at odds with each other (reviewer A: “we should change this variable name from foo to bar” -> code gets edited to bar -> reviewer B: “we should change this variable from bar to foo”).
When in these situations, I can feel the blood flow changing in my body, an increased heart beat and blood pressure. I am not at all surprised that these moments will be imprinted in one’s mind for a long time, as they can be very traumatic. I know they are for me.
This is especially true in companies with a heavy culture of code reviews, and can be terrifying when a new team member joins and you are waiting for them to reveal what their review style is going to be.
Many times it’s an exhausting “I know my code works, I know my code is fairly robust to the current challenges we are facing, I know it is well readable and commented, and yet you are shitting on it so much that if we weren’t paid to be here I would straight up just tell you to go fuck off”.
In a particular team I worked at Google, it was common to see for fairly small and reasonable PRs (100-500 LOC range including tests) get ~50 or more comments by many people, including opinionated ones. The irony was that many times the comments left by people were directly at odds with each other (reviewer A: “we should change this variable name from foo to bar” -> code gets edited to bar -> reviewer B: “we should change this variable from bar to foo”).
When in these situations, I can feel the blood flow changing in my body, an increased heart beat and blood pressure. I am not at all surprised that these moments will be imprinted in one’s mind for a long time, as they can be very traumatic. I know they are for me.