News for hackers. Stuff that matters.
Re:We're forking Flutter by Vt71fcAqt7 on Monday October 28, 2024 @08:13PM (#41978010)
I just tested Douyin 23.5 from 2022 and it does not have the two finger scroll bug.[0] It is of course possible they were carrying their own patch for it all this time but that seems unlikely. I doubt they are using Flutter or if they did it must have been a long time ago.

[0] https://github.com/flutter/flutter/issues/11884 - click on the search button and search for something to get to a regular ScrollView

Re:We're forking Flutter by refulgentis on Monday October 28, 2024 @08:32PM (#41978156)
Flutter two finger scroll "bug" is gone.

I wouldn't say its unlikely they carried a patch for it, I just wrote a framework patch that I apply at build time in CI and locally.

I refuse to sideload arbitrary APKs, especially from bytedance. I feel bad because that is irrational, you did, and it'd be really helpful if I did and just did this myself, but, you should install FlutterShark and check: https://play.google.com/store/apps/details?id=com.fluttersha...

Re:We're forking Flutter by Vt71fcAqt7 on Monday October 28, 2024 @08:46PM (#41978216)
>Flutter two finger scroll "bug" is gone.

Why is "bug" in scare quotes here? It was most definitely a bug.

>I wouldn't say its unlikely they carried a patch for it, I just wrote a framework patch that I apply at build time in CI and locally.

The actual fix was pretty involved. I doubt a large company like Bytedance would want to carry around extra patches at the gesture level that make the dev cycle more difficult. Having one person carry a patch on their local machine is a different story.

Anyway, the Bytedance blogpost says only 200 devs are using Flutter which would make no sense if it was used in Douyin, and LibChecker[0] returns no results for libflutter.so.

[0] https://github.com/LibChecker/LibChecker

Re:We're forking Flutter by refulgentis on Monday October 28, 2024 @10:33PM (#41978799)
> Why is "bug" in scare quotes here? It was most definitely a bug.

Is it? I thought it was cool, I can't think of why its disruptive to scroll a list faster if you scroll with more fingers.

> I doubt a large company like Bytedance would want to carry around extra patches at the gesture level

I'm a solo endeavour, and I spent ~30 minutes to do exactly this (patch gesture behavior) two days ago. I was stunned how easy it is. But I grew up on versioned closed source dependencies on Apple iOS frameworks that you had to patch the runtime at runtime to fix, so I'm easily wowed.

> 200 devs are using Flutter which would make no sense if it was used in Douyin

Seems reductive: "Only" 200 fulltime, 800 in the company...and we're in a discussion about how 50 maintain _the entire framework_. :)