Don't defer Close() on writable files

Re:Don't defer Close() on writable files by throwaway173920 on Tuesday September 10, 2024 @09:29AM (#41500585)

IMO the formatting of the error string returned by errors.Join is atrociously opinionated and not very logging-friendly - it adds a newline between each error message. I know I'm not the only one that has this opinion

[ Parent | on HN ]

Re:Don't defer Close() on writable files by kjksf on Tuesday September 10, 2024 @10:05AM (#41500902)

It's a trivial function: https://cs.opensource.google/go/go/+/refs/tags/go1.23.1:src/...

You could write your own errorsJoin() and change Error() method to suit your needs.

But really in this particular scenario you would be better served by something like:

    func errorsConcat(err1 error, err2 error) error {
      if (err1) {
        return err1;
      }
      return err2;
    }

And then do: err = errorsConcat(err, f.Close())

In the scenario described in this article, errors.Join() would most often reduce to that (in terms of what Error() string would produce).

[ Parent | on HN ]

Re:Don't defer Close() on writable files by Matl on Tuesday September 10, 2024 @09:43AM (#41500693)

Wouldn't you use slog if you want logging friendly?

[ Parent | on HN ]