News for hackers. Stuff that matters.
Re:gRPC: The Ugly Parts by lopkeny12ko on Friday September 06, 2024 @11:29PM (#41471275)
The criticisms the author levies against Protobuf are unfair. Inside Google, all source code is in a monorepo, and depending on other Protobuf files is a matter of code-sharing it as a Bazel library; it is trivial. There is no need for a package management system because its existence would be irrelevant.
Re:gRPC: The Ugly Parts by ronsor on Friday September 06, 2024 @11:32PM (#41471277)
> Inside Google, all source code is in a monorepo

And outside Google, it isn't. It's fair to judge something that's been released to the public based on what the public can reasonably do.

Re:gRPC: The Ugly Parts by Narhem on Friday September 06, 2024 @11:36PM (#41471286)
Yea, but from the complexities of managing external facing libraries they do an extremely well job. As a former Googler I can jump into bazel, grpc projects or start my own relatively easily.

I tried making a few guides on a personal blog explaining how to use these tools but to be honest without seeing how they get used within Google it's relatively difficult to understand why they have some of the design decisions which may seem as clunky only have decent explanations when being seen within their ecosystem.

Re:gRPC: The Ugly Parts by kelnos on Saturday September 07, 2024 @12:12AM (#41471383)
As a not-former-Googler, the last time I looked into Bazel I was confused and had no idea what I was looking at.

The world is much much much bigger than Google's internal tooling. Even Google's internal tooling that they've made public.

Re:gRPC: The Ugly Parts by marvin-hansen on Saturday September 07, 2024 @12:38AM (#41471474)
That is true. I am using Bazel daily with all deps vendored and proto defined as targets so there is really no need for these tools the author mentioned because with Bazel the underlying problems simply don't exist in the first place.

It's worth pointing out that it takes a bit of time and pain to gronk the underlying rational for some of the less obvious design decisions.

For example, Protos aren't versioned because you already version them with git. Releases usually some kind of hash, so you already have reliable dependencies with checksums. No point in versioning protos again. It's a mono repo, so why bother with distribution? Composition? Use proto lib target...

Without Bazel, though, your basically totally lost and then these tools kinda make sense as a way out of the pain caused the lacking tool support you will face.

That said, a lot of orgs have less then ideal IT for historical or whatever reasons so these problems are 100% real and these solutions exist for a reason.

Re:gRPC: The Ugly Parts by troupo on Saturday September 07, 2024 @12:48AM (#41471498)
> For example, Protos aren't versioned because you already version them with git. Releases usually some kind of hash, so you already have reliable dependencies with checksums.

Sorry, but this is such a stupid statement. You external service or client doesn't have access to your internal git hash

> That said, a lot of orgs have less then ideal IT for historical or whatever reasons

No. A lot of orgs don't require setting up Bazel to make simple things like generating code from protobufs work

Re:gRPC: The Ugly Parts by crustycoder on Saturday September 07, 2024 @03:40AM (#41472217)
It's a stupid statement internally as well. Unless you can freeze time itself, deploying new versions of stuff isn't instantaneous. And what happens if you need to do a rollback of a component?
Re:gRPC: The Ugly Parts by SR2Z on Saturday September 07, 2024 @11:02AM (#41474292)
> And what happens if you need to do a rollback of a component?

You revert the offending commit. That triggers an automatic deploy (or, even more likely, your buggy change gets caught in the canary stage and automatically reverted for you).

The Google philosophy is called "live at head" and it has a bunch of advantages, provided your engineers are disciplined enough to follow through.

Re:gRPC: The Ugly Parts by troupo on Saturday September 07, 2024 @04:13PM (#41476181)
Until you run into things like "your partners deploy once every two months" or "the team's deploy is delayed by X due to unforseen changes downstream" or ...

Protobuf is built specifically for Google and Google's way of doing things. Not everyone is built like Google.

Re:gRPC: The Ugly Parts by lopkeny12ko on Saturday September 07, 2024 @04:58PM (#41476453)
Well, the core problem is that you shouldn't be deploying as infrequently as every 2 months...you should spend engineering energy to fix that rather than on working around it.
Re:gRPC: The Ugly Parts by crustycoder on Saturday September 07, 2024 @06:00PM (#41476721)
Must be nice not to have to live in the real world.
Re:gRPC: The Ugly Parts by SR2Z on Saturday September 07, 2024 @08:46PM (#41477413)
Deploying every two months is not required to live in the real world.
Re:gRPC: The Ugly Parts by crustycoder on Sunday September 08, 2024 @03:57AM (#41478907)
Customers who expect interface stability for 12+ months is the real world.
Re:gRPC: The Ugly Parts by SR2Z on Monday September 09, 2024 @06:48PM (#41495057)
You can deploy a service with a stable interface frequently...
Re:gRPC: The Ugly Parts by crustycoder on Saturday September 07, 2024 @05:58PM (#41476709)
Yep, well said.
Re:gRPC: The Ugly Parts by crustycoder on Saturday September 07, 2024 @05:56PM (#41476703)
If you think that answer makes even the remotest sense then you really don't know what you are talking about.
Re:gRPC: The Ugly Parts by SR2Z on Saturday September 07, 2024 @08:45PM (#41477410)
I worked at Google; I'm describing to you exactly how the infrastructure worked.

Yes, Google's internal infrastructure is that good. It's easy to get caught up in the "haha cancel products" meme and forget that this company does some serious engineering.

Re:gRPC: The Ugly Parts by crustycoder on Sunday September 08, 2024 @04:02AM (#41478926)
What Google does with its internal infrastructure is of limited applicability to the majority of people, where interface stability is the prime directive.
Re:gRPC: The Ugly Parts by lopkeny12ko on Sunday September 08, 2024 @06:06AM (#41479423)
Interface stability and "living at head" are not mutually exclusive?
Re:gRPC: The Ugly Parts by SR2Z on Monday September 09, 2024 @06:49PM (#41495071)
They are not. A good interface rarely ever needs to be changed; the point of live at head is that it's impossible to commit a breaking change as long as there's a test depending on the thing you broke.
Re:gRPC: The Ugly Parts by SR2Z on Saturday September 07, 2024 @10:59AM (#41474274)
> You external service or client doesn't have access to your internal git hash

Including the build commit is very straightforward - but more to the point, Google projects frequently treat the monorepo like a service to do things like fetch the latest config. Even deployments tend to be automated through the monorepo - lots of tools make automated change requests.

Re:gRPC: The Ugly Parts by kelnos on Saturday September 07, 2024 @12:11AM (#41471380)
If Google wants to push gRPC as a general, open, standardized solution -- which they most certainly want, and have done -- then they need to cater to how everyone does things, not to how Google does things.
Re:gRPC: The Ugly Parts by ai_slurp_bot on Saturday September 07, 2024 @12:37AM (#41471470)
In a sense, everyone does things because of how google does things. How does one decide whether the chicken or the egg should follow?
Re:gRPC: The Ugly Parts by codeflo on Saturday September 07, 2024 @02:40AM (#41471964)
In what sense does "everyone do things because of how google does things"?
Re:gRPC: The Ugly Parts by forrestthewoods on Saturday September 07, 2024 @12:21AM (#41471416)
Nonsense. The criticism are perfectly fair and realistic.

Bazel is virtually unusable outside of Google. If protobuf is only usable inside Google infra then the response would be “don’t use it if you aren’t Google”. And yet I somehow doubt that’s what you’d argue!

Re:gRPC: The Ugly Parts by laidoffamazon on Saturday September 07, 2024 @01:38AM (#41471685)
How is it unfair? Is protobuf an externally available tool or not?