News for hackers. Stuff that matters.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by katzinsky on Thursday August 08, 2024 @09:16AM (#41191167)
The one time I tried to use eBPF it wasn't expressive enough for what I needed.

Does the limited flexibility it provides really justify the added kernel space complexity? I can understand it for packet filtering but some of the other stuff it's used for like sandboxing just isn't convincing.

Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by knorker on Thursday August 08, 2024 @09:24AM (#41191228)
There are other technologies for this, such as DTrace. The kernel's choice isn't eBPF or nothing, it's eBPF or something else like it.

You may not use it much, but some people use it all day. I think FAANG engineers have said that they run tens (hundreds?) of these things on all servers, all the time. And that's excluding one-offs. And FAANG has full time kernel coders on staff, so they're also funding this complexity that they use.

But also yes, I've solved problems by using eBPF. Problems that are basically unsolvable by non-kernel-gurus without eBPF. I rarely need it. But when I need it, there's nothing else that does the trick.

In some cases, even for kernel gurus, it's a choice between eBPF or maintaining a custom kernel patch forever.

Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by fch42 on Thursday August 08, 2024 @11:25AM (#41192543)
DTrace and eBPF are "not so different" in the sense that dtrace programs / hooks are also a form of low-level code / instruction set that the kernel (dtrace driver) validates at load. It's an "internal" artifact of dtrace though, https://github.com/illumos/illumos-gate/blob/master/usr/src/... and to my knowledge, nothing like a clang/gcc "dtrace target" exists to translate more-or-less arbitrary higher-level language "to low-level dtrace".

The additional flexibility eBPF gets from this is amazing really. While dtrace is a more-targeted (and for its intended usecases, in some situations still superior to eBPF) but also less-general tool.

(citrus vs. stone fruit ...)

Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by cryptonector on Thursday August 08, 2024 @12:08PM (#41193061)
DTrace's bytecode machine is also very very limited. eBPF's is much less limited. Limiting the scope of what a probe can do is very important.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by bcantrill on Thursday August 08, 2024 @01:07PM (#41193794)
Yes, thank you. Long before eBPF existed, we spent a ton of time on the safety of DTrace[0][1] -- there's a bunch of subtlety to it. The proof is in the pudding, however: thanks to our strict adherence to the safety constraint, we have absolute confidence in using DTrace in production.

[0] https://bcantrill.dtrace.org/2005/07/19/dtrace-safety/

[1] https://www.usenix.org/legacy/publications/library/proceedin..., §3.3

Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by saagarjha on Thursday August 08, 2024 @02:00PM (#41194409)
I’m curious which part of these tenets would feel would have prevented the bug demonstrated, besides “oh we tried harder”? I don’t see any of those that seem unique to DTrace other than limiting where probes can be placed.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by bcantrill on Thursday August 08, 2024 @02:16PM (#41194592)
Well, we didn't merely "try harder" -- we treated safety as a constraint which informed every aspect of the design. And yes, treating safety as a constraint rather than merely an objective results in different implementation decisions. From the article:

This working model significantly increases the attack surface of the kernel, since it allows executing arbitrary code at a high privilege level. Because of this risk, programs have to be verified before they can be loaded. This ensures that all eBPF security assumptions are met. The verifier, which consists of complex code, is responsible for this task.

Given how difficult the task of validating that a program is safe to execute is, there have been many vulnerabilities found within the eBPF verifier. When one of these vulnerabilities is exploited, the result is usually a local privilege escalation exploit (or container escape in containerized environments). While the verifier’s code has been audited extensively, this task also becomes harder as new features are added to eBPF and the complexity of the verifier grows

DTrace was developed over 20 years ago; there have not been "many vulnerabilities" found in the verifier -- and we have not grown the complexity of the verifier over time. You can dismiss these as implementation details, but these details reflect different views of the problem and its contraints.

Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by saagarjha on Thursday August 08, 2024 @02:36PM (#41194767)
No, like, the bug that was demonstrated seems to be fairly fundamental to running any sort of bytecode in the kernel: they need to verify all branches, and this is potentially slow, so they optimize it (which is where the bug is). What are you doing differently? It seems to me that you’re either not going to optimize this or you are?
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by tptacek on Thursday August 08, 2024 @03:05PM (#41195058)
The DTrace instruction set is more limited than that of the eBPF VM; eBPF is essentially a fully functional ISA, where DTrace was (if I'm remembering this right) designed around the D script language. An eBPF program is often just a clang C program, and you're trusting the kernel verifier to reject it if it can't be proven safe. Further: eBPF programs are JIT'd to actual machine code; once you've loaded and verified an eBPF program, it has conceptually all the same power as, say, shellcode you managed to load into the kernel via an LPE.

That's not to say that security researchers couldn't find DTrace vulnerabilities if they, for instance, built DIF/DOF fuzzers of 2023 levels of sophistication for them. I don't know that anyone's doing that, because DTrace is more or less a dead letter.

Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by solarengineer on Friday August 09, 2024 @11:05AM (#41202564)
For those who read this thread - DTrace is in use in Solaris and in Illumos, and various of us who use Illumos for our production use cases (like Oxide does) still very much use DTrace.

I appreciate the rest of tptacek's comment which is informative. I also acknowledge that there may not be fuzzers written that have been disclosed.

Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by tptacek on Friday August 09, 2024 @03:31PM (#41204708)
Oh, sorry, totally fair call-out. There's like a huge implicit "on Linux" thing in my brain about all this stuff.

I'd also be open to an argument that the code quality in DTrace is higher! I spent a week trying to unwind the verifier so I could port a facsimile of it to userland. It is a lot. My point about fuzzers and stuff isn't that I'm concerned DTrace is full of bugs; I'd be surprised if it was. My thing is just that everything written in memory unsafe kernel code falls against Google Project Zero-grade vulnerability research, at some point.

That's true of the rest of the kernel, too! So from a threat perspective, maybe it doesn't matter. I think my bias here --- that's all it is --- is that neither of these instrumentation schemes are things I'd want to expose to a shared-kernel cotenant.

Thanks for helping me clarify this.

Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by cryptonector on Thursday August 08, 2024 @02:10PM (#41194521)
The DTrace bytecode VM is simply more limited:

  - it cannot branch backwards (this is also true of eBPF)
  - it can only do ternary operator branches
  - it cannot define functions
  - functions it can call are limited to some builtin ones
  - it can only scribble on the one pre-allocated probe buffer
  - it can only access the probe's defined parameters
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by tptacek on Thursday August 08, 2024 @02:13PM (#41194567)
eBPF programs can absolutely branch backwards. You may be thinking of cBPF.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by cryptonector on Thursday August 08, 2024 @03:00PM (#41195004)
I was thinking of the original BPF. I didn't realize that eBPF added back branching.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by tptacek on Thursday August 08, 2024 @03:08PM (#41195084)
If the verifier can prove to itself that a loop is bounded, it'll accept it. A good starting place for eBPF itself: if a normal ARM program could do it, eBPF can do it. It's a fully functional ISA.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by cryptonector on Thursday August 08, 2024 @03:15PM (#41195165)
I'm w/ the DTrace guys on this. A turing complete VM is a bad idea for this purpose.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by tptacek on Thursday August 08, 2024 @03:29PM (#41195263)
It depends on what you're using it for. If you want to expose this to untrusted code, yes, but I wouldn't be comfortable doing that with DTrace either.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by cryptonector on Thursday August 08, 2024 @05:55PM (#41196751)
There's two untrusted code cases here: untrusted DTrace scripts / users, and untrusted targets for inspection. The latter has to be possible to examine, so the observability tools (like DTrace) have to be secure for that purpose. This means you want to make it difficult to overflow buffers in the observability tools.

There's also a need to make sure that even trusted users don't accidentally cause too much observability load. That's why DTrace has a circular probe buffer pool, it's why it drops probes under load, it's why it pre-allocates each probe's buffer by computing how much the probe's actions will write to it, it's why it doesn't allow looping (since that would make the probe's effect less predictable), etc.

Bryan, Adam, and Mike designed it this way two plus decades ago, and Linux still hasn't caught up.

Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by tptacek on Thursday August 08, 2024 @06:02PM (#41196808)
Linux has a different design than DTrace; eBPF is more capable as a trusted tool, and less capable for untrusted tools. It doesn't make sense to say one approach has "caught up" to the other, unless you really believe the verifier will reach a state where nobody's going find verifier bugs --- at which point eBPF will be strictly superior. Beyond that, it's a matter of taste. What seems clearly to be true is that eBPF is wildly more popular.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by cryptonector on Friday August 09, 2024 @12:05AM (#41198681)
It's really hard to bring a host to its knees using DTrace, yet it's quite powerful for observability. In my opinion it is better to start with that then add extra power where it's needed.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by tptacek on Friday August 09, 2024 @12:08AM (#41198693)
I understand the argument, but it's clear which one succeeded in the market. Meanwhile: we take pretty good advantage of the extra power eBPF gives us over what DTrace would, so I'm happy to be on the golden path for the platform here. Like I said, though: this is a matter of taste.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by umanwizard on Friday August 09, 2024 @04:50AM (#41200024)
eBPF isn’t Turing complete because it has to be able to prove that loops are bounded.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by cryptonector on Thursday August 08, 2024 @05:58PM (#41196778)
And I should say that DTrace probe actions can dereference pointers, but NULL dereferences do not cause crashes, and rich type data is generally available.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by rurban on Sunday August 11, 2024 @05:21PM (#41219401)
DTrace does not have arrays on purpose because they reasoned that those bounds checks will not be secure. And DTrace provides seemless tooling up into user-space scripts. Kernel, libc, scripts.

Until eBPF came around and said we can now prove it to be secure.

Until the sidechannel hackers came around to prove the opposite.

Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by lynxmachine on Thursday August 08, 2024 @09:39AM (#41191363)
> I've solved problems by using eBPF. Problems that are basically unsolvable by non-kernel-gurus without eBPF. I rarely need it.

Would you mind giving some examples? I recently started learning about ebpf's from Liz Rice's book and is curious about what makes ebpf the correct choice in a particular scenario.

Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by znpy on Thursday August 08, 2024 @10:02AM (#41191640)
> There are other technologies for this, such as DTrace. The kernel's choice isn't eBPF or nothing, it's eBPF or something else like it.

To add on this point: I successfully used SystemTap a few years ago to debug an issue i was having.

Before going further: keep in mind that my point of view (at the time) was the one of somebody working as a devops engineer, debugging some annoyances with containers (managed by Kubernetes) going OOM. I'm no kernel developer and I have a basic-good understanding of the C language based on first-years university course and geekyness/nerdyness. So in this context I'm a glorified hobbyist.

Learning SystemTap is easier in my opinion. I followed a tutorial by RedHat to get the hang of the manual parts but after that I remember being fairly easy:

1. Try to reproduce the issue you're having (fairly easy for me)

2. Skim the source code of the linux about the part that you think might be relevant (for me it was the oom killer)

3. Add probes in there, see if they fire when you reproduce the issue

4. Look back at the source code of the kernel and see what chain of data structures and fields you can follow to reach the piece of information you need

5. Improve your probes

6. If successful, you're done

7. Goto 4

I think it took like one or two days between following the tutorial and getting a working probe.

It was a pleasant couple of days.

Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by katzinsky on Thursday August 08, 2024 @09:35AM (#41191325)
I'm not sure "Google engineers use it" is a very good counter argument. They have a very high tolerance for complexity and like most large corporations what actually gets built and used tends to be driven more by internal politics than technical merit.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by eggnet on Thursday August 08, 2024 @09:41AM (#41191387)
Google would maintain a kernel patch or upstream a patch if that was the right choice for a given problem.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by katzinsky on Thursday August 08, 2024 @10:07AM (#41191698)
That's really begging the question. I don't believe they would as they have consistently over engineered solutions in the past.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by DaiPlusPlus on Thursday August 08, 2024 @07:24PM (#41197458)
> Google would maintain a kernel patch

I look forward to seeing that patch on Google Graveyard in a couple years' time.

Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by knorker on Thursday August 08, 2024 @10:35AM (#41192003)
I don't mean it as a counter argument, or I don't think the way you mean it, at least.

You may not use it at your smaller scale. But there are millions of machines out there that do use it, and the alternative for the same functionality is much worse.

I bet you never use SCTP sockets either. eBPF is used much more than SCTP.

And its users "fund" its development, so it's not a burden to those who don't use it.

But are you sure your systems don't use it? Run "bpftool prog" to see. Whatever you see there someone thought was better than the alternative.

Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by ssahoo on Thursday August 08, 2024 @10:31AM (#41191959)
Wouldn't even the classic loadable kernel mode driver be a better choice than a patch and eBpf? I know they are unsafe but people who deal with it, know the power comes with responsibility.
Re:CVE-2023-2163: How we found and fixed an eBPF Linux Kerne... by tptacek on Thursday August 08, 2024 @10:38AM (#41192023)
No? SREs roll eBPF programs on the fly just in the process of debugging problems; if you tried to do that with an LKM, you'd almost certainly blow up your system. People who write Linux kernel code routinely crash their systems in the process of development.