News for hackers. Stuff that matters.

A comment on Ask HN: What is the best code base you ever worked on?. Parent comment

Re:Ask HN: What is the best code base you ever worked on? by wavemode on Friday June 28, 2024 @10:27PM (#40827450)
People really underestimate how much productivity drain there is in having a bad code review culture. One of the worst things about working at Amazon was that any feedback on a merge request, no matter how small, required you to request a re-review.
[ Parent | on HN ]
Re:Ask HN: What is the best code base you ever worked on? by snotrockets on Wednesday July 03, 2024 @04:46PM (#40869817)
It's not culture (organic), it's systems (planned): if you don't, on day zero, agree what code reviews should cover (and what not), then code reviews are a pissing contest first, and a useful tool second.

I noticed a lot of people don't understand both the limitations of code reviews, and what issues they can and should solve. Writing good critique (of anything, not just code) is hard, we don't train people to do it, and usually don't even regard this as something that needs training and understanding.

[ Parent | on HN ]