Re:Ask HN: What is the best code base you ever worked on?
by wavemode on Friday June 28, 2024 @10:27PM
(#40827450)
People really underestimate how much productivity drain there is in having a bad code review culture. One of the worst things about working at Amazon was that any feedback on a merge request, no matter how small, required you to request a re-review.
Re:Ask HN: What is the best code base you ever worked on?
by snotrockets on Wednesday July 03, 2024 @04:46PM
(#40869817)
It's not culture (organic), it's systems (planned): if you don't, on day zero, agree what code reviews should cover (and what not), then code reviews are a pissing contest first, and a useful tool second.
I noticed a lot of people don't understand both the limitations of code reviews, and what issues they can and should solve. Writing good critique (of anything, not just code) is hard, we don't train people to do it, and usually don't even regard this as something that needs training and understanding.
Re:Ask HN: What is the best code base you ever worked on?
by ynx on Saturday June 29, 2024 @02:24AM
(#40828251)
+1.
Going from FB to $REDACTED to Oculus was a pretty wild ride, there were a lot of different cultures, though I think generally speaking the best qualities filtered through.
(also, howdy former teammate)
Re:Ask HN: What is the best code base you ever worked on?
by kridsdale3 on Saturday June 29, 2024 @04:16PM
(#40833079)
(trying to recall unixname to human name mapping.....)
My 2 cents: OWNERS is fairly useful, if only as a form of automating code reviewer selection. Readabilty is a massive drag on org-wide productivity. I have had diffs/CLs take MONTHS to be approved by every Tom Dick and Harry whose claws were added to my code and made me re-design whole project approaches, and they were only there because they're supposed to check if my new-lines are in the right spot for that language. I thought about quitting.