Has there been a 20 year stretch of time in the US in which housing is broadly a depreciating asset?
Seems that land is definitely, and housing for the most part, an appreciating asset over time due to scarcity.
you are asking if real estate prices have fallen over a 20 year period in the US and the answer is not in the modern inflationary era:
https://fred.stlouisfed.org/series/QUSR628BIS
but that mixes land & housing prices together of course
prices have fallen over 10 year periods (sometimes dramatically) however, and the average length of ownership is 8 years, so timing can make a huge difference in outcomes of home ownership, particularly with the leverage involved.
The Great Depression started early for farmers...
https://ag.purdue.edu/commercialag/home/resource/2023/08/the...
debt for productive activity in general makes sense if it isn't compounding (mortgages act like simple interest, btw, although it's complicated since you pay more interest at the start of the loan and so if you move within the first five years you've paid almost entirely interest on the home)
debt for consumption is always parasitic
that's why it's insane how hard it is to get a business loan and how easy it is to get a credit card: usurers want suckers, not shared risk on productive investments