Re:The Performance Impact of C++'s `final` Keyword
by cogman10 on Monday April 22, 2024 @04:20PM
(#40119664)
And to your original comment, I think the reviewer was wrong to reject the PR over that. Performance has to be measured before you can use it to reject (or create...) a PR. If someone hasn't done that then unless it's something obvious like "You are making a ton of tiny heap allocations in a tight loop" then I think nitpicking these sorts of things is just wrong.
[ Parent
| on HN ]
There are no comments on this comment yet.