News for hackers. Stuff that matters.
Re:The Performance Impact of C++'s `final` Keyword by tombert on Monday April 22, 2024 @04:12PM (#40119437)
I agree with what you said but in this particular case, it actually was a direct integer equality check, there was zero risk of hitting side effects and that was plainly obvious to me, the checker, and compiler.
Re:The Performance Impact of C++'s `final` Keyword by cogman10 on Monday April 22, 2024 @04:20PM (#40119664)
And to your original comment, I think the reviewer was wrong to reject the PR over that. Performance has to be measured before you can use it to reject (or create...) a PR. If someone hasn't done that then unless it's something obvious like "You are making a ton of tiny heap allocations in a tight loop" then I think nitpicking these sorts of things is just wrong.