News for hackers. Stuff that matters.

A comment on Xz: Can you spot the single character that disabled Linux landlock?. Parent comment

Re:Xz: Can you spot the single character that disabled Linux... by Aeolun on Saturday March 30, 2024 @08:33PM (#39880148)
I feel like my version control system is better about highlighting the changed characters than these solid green or red strings.
[ Parent | on HN ]
Re:Xz: Can you spot the single character that disabled Linux... by XorNot on Saturday March 30, 2024 @08:49PM (#39880259)
I don't love unified diffs as a rule either. They're very noisy to read in general.

A side by side in something like "meld" will highlight changes but also means you're reading the full context as it will exist in the code base.

My number one complaint about "code review" is the number of people who simply run their eyes over the diff (in private orgs) because management says "code review" and that's as far as they ever take that in terms of defining outcomes.

[ Parent | on HN ]
Re:Xz: Can you spot the single character that disabled Linux... by eru on Saturday March 30, 2024 @10:22PM (#39880771)
I love unified diffs for many applications. You are right that side by side diffs have their uses, too.
[ Parent | on HN ]
Re:Xz: Can you spot the single character that disabled Linux... by TheRealPomax on Saturday March 30, 2024 @08:36PM (#39880165)
It's git, so it can show a vastly better diff, just not from a URL with hardcoded diff settings.
[ Parent | on HN ]
Re:Xz: Can you spot the single character that disabled Linux... by Aeolun on Saturday March 30, 2024 @08:48PM (#39880253)
Yeah, but I’m wondering where the code review was done. In a different context, would this be easier to spot?
[ Parent | on HN ]
Re:Xz: Can you spot the single character that disabled Linux... by masklinn on Sunday March 31, 2024 @02:26AM (#39881919)
It’s a giant block of new code, what is it supposed to do beyond tell you it’s a giant block of new code?

Note that this is C code inside if a cmake string, even if your diff can do highlighting the odds it would highlight that are low, and if it did highlighting is generally just lexing so there wouldn’t be much to show.

[ Parent | on HN ]