Re:Your GitHub pull request workflow is slowing everyone down
by mpweiher on Friday February 23, 2024 @08:30AM
(#39480330)
So it's a workaround for "even small PRs take too long to review"?
[ Parent
| on HN ]
Re:Your GitHub pull request workflow is slowing everyone down
by Denvercoder9 on Friday February 23, 2024 @08:46AM
(#39480486)
No, it's a solution for reviews being an asynchronous process. Even if I get a review within an hour or two, I should be able to continue further work in that time.
Re:Your GitHub pull request workflow is slowing everyone down
by from-nibly on Friday February 23, 2024 @09:41AM
(#39481092)
Isn't it often better to get a single thing all the way through? I know it feels like you are still working on the same feature, but if you want feedback you shouldn't move onto something else while waiting for it. That completely scrambles your flow.
Craming your day with as much "work" as possible isn't faster.
Re:Your GitHub pull request workflow is slowing everyone down
by Denvercoder9 on Friday February 23, 2024 @02:32PM
(#39485086)
I don't necessarily create the first PR because I want feedback. The design could've been discussed beforehand, and the PR is just to get a second set of eyes on the details, run the CI checks and to fulfill the review requirements. Nothing that comes out of that would have implications for the follow-on PRs, so why shouldn't I continue working on them?
Re:Your GitHub pull request workflow is slowing everyone down
by from-nibly on Sunday February 25, 2024 @01:26AM
(#39498212)
> is just to get a second set of eyes on the details, run the CI checks and to fulfill the review requirements
AKA feedback