Re:My Notes on Gitlab's Postgres Schema Design (2022)
by serial_dev on Sunday February 18, 2024 @06:49AM
(#39418302)
> In gitlabs case this is much less relevant (...)
Why, though? GitLab is often self hosted, so being able to iterate through objects, like users, can be useful for an attacker.
Re:My Notes on Gitlab's Postgres Schema Design (2022)
by remus on Sunday February 18, 2024 @12:57PM
(#39421296)
You're right, fair point.
Re:My Notes on Gitlab's Postgres Schema Design (2022)
by yellowapple on Sunday February 18, 2024 @02:22PM
(#39422172)
In my experience self-hosted GitLabs are rarely publicly-accessible in the first place; they're usually behind some sort of VPN.
As for an attacker being able to iterate through users, if that information is supposed to be private, and yet an attacker is getting anything other than a 404, then that's a problem in and of itself and my energy would be better spent fixing that.
Re:My Notes on Gitlab's Postgres Schema Design (2022)
by Anon1096 on Monday February 19, 2024 @12:23AM
(#39426470)
This is again a defense in depth thing. In the age of WFH, cracking a corporate VPN is really not that difficult. If you can make an attacker's life harder for low cost you should do it just in case.
Re:My Notes on Gitlab's Postgres Schema Design (2022)
by yellowapple on Monday February 19, 2024 @11:11AM
(#39431352)
Except you ain't really putting up a meaningful obstacle against an attacker here. Compared to the typical effort of cracking a corporate VPN, brute-forcing IDs is downright trivial.
Like I said elsewhere: it's like calling ROT13 "defense in depth".
For example, imagine you're poking around a system that uses incrementing ints as public identifiers. Immediately, you can make a good guess that there's probably going to be some high privileged users with user_id=1..100 so you can start probing around those accounts. If you used UUIDs or similar then you're not leaking that info.
In gitlabs case this is much less relevant, and it's more fo a cosmetic thing.