It implies nothing. You can politely open an issue and ask why HeaderMap is used instead of HashMap. As long as you’re polite, it’ll be fine.
> unsafe might as well be unsound.
Oh boy, hope you don’t open Vec in the standard library. It can’t be implemented without unsafe and it’s used by almost all Rust programs. I guess every program is unsound, according to you?
> Ok, and that doesn't mention "unsafe" once
Nor does it need to. Just because OP decided this is a problem doesn’t mean it actually is a problem. Find unsoundness and then you have something worth discussing.
I have direct personal experience that opening an issue to politely ask this kind of design question is not always fine.
> Oh boy, hope you don’t open Vec in the standard library. It can’t be implemented without unsafe and it’s used by almost all Rust programs. I guess every program is unsound, according to you?
Based on past experience with LLVM undefined behaviour, yes, I think it's highly likely that every existing nontrivial Rust program is unsound in current Rust. But "depends on a standard library class that is currently implemented unsafely" will be much easier to fix in the future than "uses unsafe itself".
> Nor does it need to. Just because OP decided this is a problem doesn’t mean it actually is a problem. Find unsoundness and then you have something worth discussing.
Again, why use Rust at all if that's how you feel?
See https://news.ycombinator.com/item?id=39173369 for more.
Is Hyper all contained inside unsafe block? As far as I know it is not. So even if there is some unsafe code it is not same as writing it in C.
Opening an issue comes across as a whole lot more aggressive to me. That implies that they owe you an explanation or you want them to change their code.
> They cry about the existence of some unsafe code, but don’t actually put in the effort to figure out if it can lead to a real problem like unsoundness.
unsafe might as well be unsound. The key benefit of Rust is supposed to be better memory safety than C; if everything is using unsafe, why bother?
> Here’s a post by the maintainer of hyper about what they accomplished in 2023 and what they hope to accomplish in 2024 - https://seanmonstar.com/blog/2023-in-review/
Ok, and that doesn't mention "unsafe" once - no justification for why it's used, much less a plan to reduce or eliminate it.