https://en.wikipedia.org/wiki/HTC_Desire_Z <- this was an android phone with a keyboard, and far from the only one.
I think that if people kept buying these in significant enough numbers, manufacturers would still be making them.
There are a lot of very vocal niches. I got real excited when Apple put out the iPhone 12 mini, I even bought one. But the rest of the market said no, and now there is no more Mini-sized iPhone. We may be noisy, but our niche is not large enough to sustain the devices we want.
As a side note, there are still good Android phones with expandable storage, they just aren't made by Google or Samsung. Sony still makes them.
Those phones were also the best MP3 players I ever owned - I had an iPod touch at the same time and the UX of copying over/selecting/playing music on that simply didn't compare.
The problem is that iPhone and Android were stealing users from that pool. Lots of BB users loved the physical keyboard, but I feel many of them were fairly easily lured away by the greater functionality offered by touchscreens. BB actually tried to hold on to this niche for quite a while, they didn't launch their touchscreen-centric BlackBerry 10 line until 2013.
I regularly miss having a physical keyboard on my phone, but I'm not sure I would give up things like good web browsing, watching videos, or rich maps to make it happen. People are ultimately willing to downgrade their experience in a few activities like messaging in order to make other activities like web browsing actually viable.