Re:Oxlint – written in Rust – 50-100 Times Faster than ESLint
by arp242 on Friday December 15, 2023 @12:16PM
(#38656187)
One problem is that a change in a.js may trigger a new error in b.js.
ESLint could also cache things fairly trivially:
hash = hash_file_contents()
if previously_seen_hashes.contains(hash)
report_previous_results()
else
run_lint_and_cache_results()
end
maybe that already exists. But that has the same problem.When you've got enough hardware to throw at it, then "just run it on the full code" is the safest.
Re:Oxlint – written in Rust – 50-100 Times Faster than ESLint
by throwup238 on Friday December 15, 2023 @09:46AM
(#38654675)
Typescript lints are type-aware so you can’t just lint changed files, you have to relint the entire codebase to check if any type changes have impacted the unchanged code.
Re:Oxlint – written in Rust – 50-100 Times Faster than ESLint
by pcthrowaway on Friday December 15, 2023 @10:11AM
(#38654911)
Wouldn't an issue with a type change be caught at typescript compile/check steps?
I'm not aware of eslint rules which would complain about some other untouched file if types have changed in ways such that the program still compiles
Re:Oxlint – written in Rust – 50-100 Times Faster than ESLint
by anamexis on Friday December 15, 2023 @10:32AM
(#38655101)
A few examples of typescript-eslint rules that could fail when a type in another file is changed:
https://typescript-eslint.io/rules/await-thenable/
https://typescript-eslint.io/rules/no-for-in-array
https://typescript-eslint.io/rules/no-duplicate-type-constit...
But I'm generally working in a (human & financially) resource-constrained environment.